Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing dependency on filter-obj #782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renanbym
Copy link

removing dependency on filter-obj

dependency has been causing problems since the >4.0.0 update

@renanbym
Copy link
Author

@erezrokah do u have time to see this PR?

@RyanD1996
Copy link

looks good!

@erezrokah
Copy link
Owner

Hi everyone, I'm currently on vacation and will be able to take a look only in a week or two

@Cabeda
Copy link

Cabeda commented Aug 11, 2023

Hey! Any updates on this?

Copy link
Owner

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @renanbym and sorry for just responding now.

I'd prefer if we find a solution that doesn't require inlining dependencies as that comes with the following disadvantages:

  1. Is copy pastes code from another open source project without giving credit to the original author
  2. It doesn't include any test coverage for the copy pasted code
  3. It means we won't get fixes or updates to the copy pasted code

Regarding this specific change it seems the underlying issue is with Jest support of ESM. I didn't have the time to respond to the issue with a valid configuration, but the example here runs with Jest and a version of aws-testing-library that uses filter-obj.

The plan is to make aws-testing-library ESM only too (once I have time to do it).

@serverlesspolska
Copy link

This is probably related to that issue.

After updating aws-testing-library from 1.1.1 to 4.0.6 this error appeared:

  ● Test suite failed to run

    Must use import to load ES Module: /<path>/node_modules/filter-obj/index.js

What do you think I should do?

@erezrokah, what's the progress on making aws-testing-library ESM only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants