Skip to content

Commit

Permalink
Fix: Enable required extensions only
Browse files Browse the repository at this point in the history
  • Loading branch information
localheinz committed Dec 31, 2021
1 parent 54dad39 commit 3c4a6d5
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 17 deletions.
23 changes: 13 additions & 10 deletions .github/workflows/integrate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ on: # yamllint disable-line rule:truthy
branches:
- "main"

env:
PHP_EXTENSIONS: "mbstring"

jobs:
code-coverage:
name: "Code Coverage"
Expand All @@ -33,7 +30,7 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "xdebug"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"
php-version: "${{ matrix.php-version }}"

- name: "Set up problem matchers for phpunit/phpunit"
Expand Down Expand Up @@ -92,7 +89,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Validate composer.json and composer.lock"
Expand Down Expand Up @@ -153,7 +151,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Determine composer cache directory"
Expand Down Expand Up @@ -198,7 +197,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "xdebug"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Determine composer cache directory"
Expand Down Expand Up @@ -251,7 +251,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pcntl, pdo, phar, posix, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Determine composer cache directory"
Expand Down Expand Up @@ -305,7 +306,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Determine composer cache directory"
Expand Down Expand Up @@ -394,7 +396,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Set up problem matchers for phpunit/phpunit"
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/renew.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on: # yamllint disable-line rule:truthy
schedule:
- cron: "0 0 1 1 *"

env:
PHP_EXTENSIONS: "mbstring"

jobs:
license:
name: "License"
Expand All @@ -33,7 +30,8 @@ jobs:
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "none"
extensions: "${{ env.PHP_EXTENSIONS }}"
extensions: "none, ctype, dom, iconv, mbstring, pdo, phar, simplexml, tokenizer, xml, xmlwriter"

php-version: "${{ matrix.php-version }}"

- name: "Validate composer.json and composer.lock"
Expand Down
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"ext-ctype": "*",
"ext-iconv": "*",
"ext-mbstring": "*",
"ext-pdo": "*",
"doctrine/annotations": "^1.13.2",
"doctrine/collections": "^1.6.8",
"doctrine/doctrine-bundle": "^2.5.4",
Expand Down
7 changes: 4 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3c4a6d5

Please sign in to comment.