add grantless operations #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add possibility for grantless requests
|
@ericcj pinging you in case you didn't get notification and are interested! |
ericcj
approved these changes
Oct 20, 2023
| @@ -47,6 +47,12 @@ require 'fulfillment-outbound-api-model' | |||
| Rails.cache.write("SPAPI-TOKEN-#{access_token_key}", token[:access_token], expires_in: token[:expires_in] - 60) | |||
| end | |||
| config.get_access_token = -> (access_token_key) { Rails.cache.read("SPAPI-TOKEN-#{access_token_key}") } | |||
|
|
|||
| # optional lambdas for caching grantless LWA access token instead of requesting it each time, e.g.: | |||
| config.save_grantless_access_token = -> (access_token_key, token) do | |||
There was a problem hiding this comment.
the lambdas already take an "access_token_key" which is the cache key to save the token under, let's use the same lambdas just vary the key similar to what i did for RDT https://github.com/ericcj/amz_sp_api/pull/55/files#diff-e2f2fe4083a87c67a20260d6f13385b63f2b64f0cabdcdf4e2f332fa754fbb5bR16
that way we can also remove the indirection of using public_send as well
and after that change the only readme update needed should be to clarify that refresh_token isn't required if you want to use only using grantless operations.
|
@ericcj will do sometime in upcoming week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr checks whether request is being made to an endpoint which requires grantless access token.
Endpoints gathered from- https://developer-docs.amazon.com/sp-api/docs/grantless-operations
Relevant issues:
#38
#3
Tested with notification endpoints. Code is not affecting any of generated code parts, so that shouldn't be an issue.