Solve issue #244 #246
Closed
Solve issue #244 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve issue #244. When `viewsPath` is truthy, the `partialsDir` which have the directories defined by the user on the constructor, are overwritten by as single String `path.join(viewsPath, 'partials/')`. I'm playing safe here, I assume `partialsDir` is internally always dealt as an Array and therefore I convert it to an Array, pushing when appropriate the default `path.join(viewsPath, 'partials/')`, but keeping the previously defined `partialDirs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issue #244. When
viewsPathis truthy, thepartialsDirwhich have the directories defined by the user on the constructor, are overwritten by as single Stringpath.join(viewsPath, 'partials/'). I'm playing safe here, I assumepartialsDiris internally always dealt as an Array and therefore I convert it to an Array, pushing when appropriate the defaultpath.join(viewsPath, 'partials/'), but keeping the previously definedpartialDirs