Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Rewrite sup-tree view #55

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[WIP] - Rewrite sup-tree view #55

wants to merge 10 commits into from

Conversation

baransu
Copy link
Contributor

@baransu baransu commented May 26, 2017

Finally ready for testing! 馃帀 I've rewritten /sup-tree plugin to new graph library. Previously we were using vivagraphjs but it wasn't perfect for our needs. This PR changes it to sigmajs. It has better labels system, better layout algorithm (it still requires adjusting settings for our needs but it's easier to control it's behaviour than previously), easier renderer extensions. Potential issue could be distance between nodes when we have large graphs or when application has very small supervision tree.

Major changes are:

  • Faster first render with big trees. Previously it took a lot to show graph, right now we show how layout if forming instead of waiting for correct positions before first render.
  • Labels! 馃帀 馃帀 馃帀 It's a lot easier to identify application when root supervisor has correct label!
  • Create wrapper for plugin view which can be reused between other plugins. It adds unified loader and resizable right side panel. In future it would be possible to create better API for side panels on every side (top, bottom, left, right) as well as option to toggle anyone of them on and off.
  • Circle nodes (instead of square)! Other shapes possible, up to discussion 鈽猴笍

Right now it's still work in progress but core features are done so I'm counting on your feedback!

  • center camera on application when selecting
  • fix selecting nodes when layout is still forming
  • dragging nodes (I've started working on it and may be complicated, I don't know how it will play with layout algorithm)
  • update side panel layout and style (It's very raw right now, needs more polishing)
  • toggle labels (when we have a lot of workers in one place it gets messy, needs ability to disable/enable labels rendering)

@baransu
Copy link
Contributor Author

baransu commented May 29, 2017

Center camera when single process or application from list is clicked. With cool animation!
This is little hacky so I hope it won't break in the future.

@baransu baransu self-assigned this Jun 6, 2017
Copy link
Member

@michalslaski michalslaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baransu thanks for your efforts to improve the supervision tree view! I like the labels appearing on top of each process. I found it less easy to zoom-in, zoom-out and at the same time click and explore the supervision tree. Mainly because every click automatically zooms out and also because sometimes two applications appear tangled.

@danielvamosi from @digitalnatives said during his recent presentation [1] that he would like to contribute his supervision tree renderer to erlangpl. Maybe we can arrange a call to discuss his and yours efforts?

[1] https://www.youtube.com/watch?v=XLOrFRgmczU

@baransu
Copy link
Contributor Author

baransu commented Jun 19, 2017

It would be awesome. I've just seen @danielvamosi talk and tool looks awesome. I would be more than happy to integrate it as our supervision-tree visualisation 馃槉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants