Work around OTP applications which do not respond #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baransu
requested review from
arkgil,
michalslaski,
mentels,
Hajto and
mkacper
arkgil
suggested changes
Nov 6, 2017
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| -behaviour(gen_server). | |||
|
|
|||
| -define(LIVENESS_TIMEOUT, 1000). | |||
There was a problem hiding this comment.
I'd rename this to something more meaningful, maybe TOP_SUP_RESP_TIMEOUT?
|
Thanks for this @rickpayne 👍 I think it's a great addition! But I think we would need to indicate the timeout in the UI - currently the application will be present but with no nodes in the tree. I've left one comment regarding the code itself 🙂 |
|
Ok, I'll fix the current pull. Do you want me to look at indicating the fact that application timed out? It'd be a while before I get a chance... |
|
IMO that'd be great to have in the same PR, no rush 🙂 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for #60 - a bit of a nasty hack that works for me. Feel free to improve ;)