Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a remote and a local crash scenario #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wschroeder
Copy link

  • Some applications do not start supervisor children (CRITICAL)
  • More safely handle race condition of ETS tables vanishing mid-query

This code filters out children that are not supervisors so we can avoid
crashing remote processes that do not handle the which_children message.

I marked this as critical, as monitoring should not crash remote
systems.
The time between ets:all/0 and the series of ets:info/1 is enough time
for tables that exist in ets:all/0's output to vanish in systems with
temporary process trees. This code filters out the caught crashes due to
the tables not existing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant