Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Erlang/OTP 26 + Elixir 1.14 on top Windows #191

Merged
merged 5 commits into from
Jun 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ jobs:
fail-fast: false
matrix:
combo:
- otp-version: '26.0'
elixir-version: 'v1.14-otp-25'
os: 'ubuntu-latest'
version-type: 'strict'
- otp-version: '26.0'
elixir-version: '1.14.5'
os: 'ubuntu-latest'
version-type: 'strict'
- otp-version: '25.2'
elixir-version: '1.14.3'
os: 'ubuntu-latest'
Expand Down Expand Up @@ -106,7 +114,7 @@ jobs:
- elixir-version: '1.10.3'
otp-version: '22.3.4.1'
os: 'ubuntu-20.04'
- elixir-version: 'master'
- elixir-version: 'main'
otp-version: '23.1'
os: 'ubuntu-20.04'
- elixir-version: 'main'
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ jobs:
fail-fast: false
matrix:
combo:
- otp-version: '26.0'
elixir-version: 'main'
os: 'windows-latest'
version-type: 'strict'
- otp-version: '26.0'
elixir-version: 'v1.14-otp-25'
os: 'windows-latest'
version-type: 'strict'
- otp-version: '26.0'
elixir-version: '1.14.5'
os: 'windows-latest'
version-type: 'strict'
- otp-version: '25'
rebar3-version: 'nightly'
os: 'windows-latest'
Expand Down Expand Up @@ -61,6 +73,7 @@ jobs:
elixir-version: ${{matrix.combo.elixir-version}}
gleam-version: ${{matrix.combo.gleam-version}}
rebar3-version: ${{matrix.combo.rebar3-version}}
version-type: ${{matrix.combo.version-type}}
- name: Erlang/OTP version (action)
run: echo "Erlang/OTP ${{steps.setup-beam.outputs.otp-version}}"
- name: Elixir version (action)
Expand Down
96 changes: 78 additions & 18 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9719,6 +9719,9 @@ const os = __nccwpck_require__(2037)
* @param {string[]} hexMirrors
*/
async function installOTP(osVersion, otpVersion, hexMirrors) {
let cmd
let args

if (hexMirrors.length === 0) {
throw new Error(
`Could not install Erlang/OTP ${otpVersion} from any hex.pm mirror`,
Expand All @@ -9743,15 +9746,19 @@ async function installOTP(osVersion, otpVersion, hexMirrors) {
cachedPath = await tc.cacheDir(extractPath, 'otp', fullVersion)
}

await exec(path.join(cachedPath, 'Install'), ['-minimal', cachedPath])
cmd = path.join(cachedPath, 'Install')
args = ['-minimal', cachedPath]
await exec(cmd, args)

const otpPath = path.join(cachedPath, 'bin')

core.addPath(otpPath)
core.exportVariable('INSTALL_DIR_FOR_OTP', cachedPath)

core.info('Installed Erlang/OTP version')
await exec(path.join(otpPath, 'erl'), ['-version'])
cmd = path.join(otpPath, 'erl')
args = ['-version']
await exec(cmd, args)
} else if (OS === 'win32') {
if (!cachedPath) {
const exePath = await tc.downloadTool(
Expand All @@ -9765,13 +9772,19 @@ async function installOTP(osVersion, otpVersion, hexMirrors) {
const otpPath = path.join(otpDir, 'bin')

await fs.promises.mkdir(otpDir, { recursive: true })
await exec(path.join(cachedPath, 'otp.exe'), ['/S', `/D=${otpDir}`])

cmd = path.join(cachedPath, 'otp.exe')
args = ['/S', `/D=${otpDir}`]
await exec(cmd, args)

core.addPath(otpPath)
core.exportVariable('INSTALL_DIR_FOR_OTP', otpDir)

core.info('Installed Erlang/OTP version')
await exec(path.join(otpPath, 'erl'), ['+V'])

cmd = path.join(otpPath, 'erl.exe')
args = ['+V']
await exec(cmd, args)
}
} catch (err) {
core.info(`Install OTP failed for mirror ${hexMirror}`)
Expand All @@ -9787,6 +9800,10 @@ async function installOTP(osVersion, otpVersion, hexMirrors) {
* @param {string[]} hexMirrors
*/
async function installElixir(elixirVersion, hexMirrors) {
let cmd
let args
let options

if (hexMirrors.length === 0) {
throw new Error(
`Could not install Elixir ${elixirVersion} from any hex.pm mirror`,
Expand All @@ -9796,6 +9813,7 @@ async function installElixir(elixirVersion, hexMirrors) {

try {
let cachedPath = tc.find('elixir', elixirVersion)
const OS = process.platform

if (!cachedPath) {
const zipPath = await tc.downloadTool(
Expand All @@ -9813,7 +9831,21 @@ async function installElixir(elixirVersion, hexMirrors) {
core.exportVariable('INSTALL_DIR_FOR_ELIXIR', cachedPath)

core.info('Installed Elixir version')
await exec(path.join(elixirPath, 'elixir'), ['-v'])

if (debugLoggingEnabled()) {
core.exportVariable('ELIXIR_CLI_ECHO', 'true')
}

if (OS === 'linux') {
cmd = path.join(elixirPath, 'elixir')
args = ['-v']
options = {}
} else if (OS === 'win32') {
cmd = path.join(elixirPath, 'elixir.bat')
args = ['-v']
options = { windowsVerbatimArguments: true }
}
await exec(cmd, args, options)

await fs.promises.mkdir(escriptsPath, { recursive: true })
} catch (err) {
Expand All @@ -9829,12 +9861,18 @@ async function installElixir(elixirVersion, hexMirrors) {
* @param {string} gleamVersion
*/
async function installGleam(gleamVersion) {
let cmd
let args

const OS = process.platform
if (OS === 'linux') {
await exec(__nccwpck_require__.ab + "install-gleam.sh", [gleamVersion])
cmd = __nccwpck_require__.ab + "install-gleam.sh"
args = [gleamVersion]
await exec(__nccwpck_require__.ab + "install-gleam.sh", args)
} else if (OS === 'win32') {
const script = __nccwpck_require__.ab + "install-gleam.ps1"
await exec(`pwsh.exe ${script} -VSN:${gleamVersion}`)
cmd = `pwsh.exe ${path.join(__dirname, 'install-gleam.ps1')}`
args = [`-VSN:${gleamVersion}`]
await exec(cmd, args)
}
}

Expand All @@ -9844,12 +9882,18 @@ async function installGleam(gleamVersion) {
* @param {string} rebar3Version
*/
async function installRebar3(rebar3Version) {
let cmd
let args

const OS = process.platform
if (OS === 'linux') {
await exec(__nccwpck_require__.ab + "install-rebar3.sh", [rebar3Version])
cmd = __nccwpck_require__.ab + "install-rebar3.sh"
args = [rebar3Version]
await exec(__nccwpck_require__.ab + "install-rebar3.sh", args)
} else if (OS === 'win32') {
const script = __nccwpck_require__.ab + "install-rebar3.ps1"
await exec(`pwsh.exe ${script} -VSN:${rebar3Version}`)
cmd = `pwsh.exe ${path.join(__dirname, 'install-rebar3.ps1')}`
args = [`-VSN:${rebar3Version}`]
await exec(cmd, args)
}
}

Expand All @@ -9861,6 +9905,10 @@ function checkPlatform() {
}
}

function debugLoggingEnabled() {
return !!process.env.RUNNER_DEBUG
}

module.exports = {
installOTP,
installElixir,
Expand Down Expand Up @@ -10128,7 +10176,6 @@ async function getOTPVersions(osVersion, hexMirrors) {
'https://api.github.com/repos/erlang/otp/releases?per_page=100'
otpVersionsListings = await get(originListing, [1, 2, 3])
}
debugLog(`OTP versions listings from ${originListing}`, otpVersionsListings)

const otpVersions = new Map()

Expand All @@ -10141,6 +10188,7 @@ async function getOTPVersions(osVersion, hexMirrors) {
.match(/^([^ ]+)?( .+)/)[1]
.match(/^([^-]+-)?(.+)$/)
const otpVersion = otpMatch[2]
debugLog('OTP line and parsing', [line, otpVersion, otpMatch])
otpVersions.set(otpVersion, otpMatch[0]) // we keep the original for later reference
})
} else if (process.platform === 'win32') {
Expand All @@ -10152,10 +10200,17 @@ async function getOTPVersions(osVersion, hexMirrors) {
.forEach((x) => {
const otpMatch = x.name.match(/^otp_win64_(.*).exe$/)
const otpVersion = otpMatch[1]
debugLog('OTP line and parsing', [otpMatch, otpVersion])
otpVersions.set(otpVersion, otpVersion)
})
})
}

debugLog(
`OTP versions from ${originListing}`,
JSON.stringify([...otpVersions.entries()]),
)

return otpVersions
}

Expand Down Expand Up @@ -10262,7 +10317,7 @@ function maybeCoerced(v) {
try {
ret = semver.coerce(v).version
} catch {
// some stuff can't be coerced, like 'master'
// some stuff can't be coerced, like 'main'
ret = v
}

Expand Down Expand Up @@ -10445,11 +10500,16 @@ function jsonParseAsList(maybeJson) {
}

function debugLog(groupName, message) {
if (process.env.RUNNER_DEBUG) {
core.startGroup(`Debugging for ${groupName}`)
core.debug(message)
core.endGroup()
}
const group = `Debugging for ${groupName}`
core.debug(
'┌──────────────────────────────────────────────────────────────────────────',
)
core.debug(`│ ${group} - start`)
core.debug(message)
core.debug(`│ ${group} - stop`)
core.debug(
'└──────────────────────────────────────────────────────────────────────────',
)
}

module.exports = {
Expand Down