Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to work with one or more hex.pm mirrors #197

Merged
merged 2 commits into from
May 4, 2023

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented May 1, 2023

This is a successor of #156 (see #194 )

Add a new option called hexpm-mirrors for one or more hex.pm mirrors.
Default list is builds.hex.pm, so behavior is unaffected unless option is
used.

Mirrors will help mitigate recent (and older) issues with official hex.pm mirrors reliability, especially in the context of repositories for which CI performs many queries, some of which may get HTTP errors such as the 502 currently observed.

Add a new option called `hexpm-mirrors` for one or more hex.pm mirrors.
Default list is `builds.hex.pm`, so behavior is unaffected unless option is
used.

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot mentioned this pull request May 1, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented May 2, 2023

I think the default builds.hex.pm should always be the last fallback. @ericmj, thoughts?

In any case, I think it's best the option is named alternative-hexpm-mirrors, as mentioned here.

README.md Outdated Show resolved Hide resolved
@pguyot
Copy link
Contributor Author

pguyot commented May 2, 2023

I think the default builds.hex.pm should always be the last fallback. @ericmj, thoughts?

In any case, I think it's best the option is named alternative-hexpm-mirrors, as mentioned here.

It does not make much sense to force users to use a default fallback mirror. They should know better if they use the option. hex.pm doesn't do that. Plus it makes testing harder.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ericmj
Copy link
Collaborator

ericmj commented May 2, 2023

I think the default builds.hex.pm should always be the last fallback. @ericmj, thoughts?

I don't think it has to be the last fallback but we should document that if you override mirrors then it will be removed and have an example that shows how to add it to the end.

Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented May 3, 2023

No further implementation -based comments at this moment.

@pguyot, CI is failing. Did you run npm run build-dist and push everything generated locally (that's not .gitignored?)

Edit: nvm, it seems the issue was introduced here, so not related to your changes.

@paulo-ferraz-oliveira
Copy link
Collaborator

@ericmj, I'm good to merge. This does not change default behaviour and should be exercised shortly. Do we wanna merge now?

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit cf692c3 into erlef:main May 4, 2023
58 of 60 checks passed
@pguyot pguyot deleted the w46/add-cache-for-hex.pm branch May 4, 2023 06:51
@paulo-ferraz-oliveira
Copy link
Collaborator

Released in v1.16.0 / v1.16. Tag v1 moved up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants