-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option to work with one or more hex.pm mirrors #197
New option to work with one or more hex.pm mirrors #197
Conversation
Add a new option called `hexpm-mirrors` for one or more hex.pm mirrors. Default list is `builds.hex.pm`, so behavior is unaffected unless option is used. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
I think the default In any case, I think it's best the option is named |
It does not make much sense to force users to use a default fallback mirror. They should know better if they use the option. hex.pm doesn't do that. Plus it makes testing harder. |
I don't think it has to be the last fallback but we should document that if you override mirrors then it will be removed and have an example that shows how to add it to the end. |
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com> Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@ericmj, I'm good to merge. This does not change default behaviour and should be exercised shortly. Do we wanna merge now? |
Released in |
This is a successor of #156 (see #194 )
Add a new option called
hexpm-mirrors
for one or more hex.pm mirrors.Default list is
builds.hex.pm
, so behavior is unaffected unless option isused.
Mirrors will help mitigate recent (and older) issues with official hex.pm mirrors reliability, especially in the context of repositories for which CI performs many queries, some of which may get HTTP errors such as the 502 currently observed.