Ease debugging, fix some CI issues, tweak folder structure #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that one mirror fails in the above test and others follow working is test enough for me A single failing mirror should fail, but it's confusing to have an error annotation for a success (via continue-on-error) while not being able to suppress it via GitHub Actions
Might simply be that the bug is already fixed and we need to bump rebar3
We're getting Access Denied for Fetching registry from "https://repo.hex.pm:443/registry.ets.gz?"
paulo-ferraz-oliveira
changed the title
paulo-ferraz-oliveira
changed the title
ericmj
approved these changes
May 7, 2023
| if: ${{ steps.failing-setup-beam.outcome == 'success' }} | ||
| run: | | ||
| echo "Action is expected to fail" | ||
| exit 1 |
There was a problem hiding this comment.
We get an annotation with an error, which lead us to think that there was an issue, but then there wasn't because the action is ✅. It's basically very misleading. We can add a non-workflow action test (e.g. JavaScript) to test the same condition, though, if it's absolutely necessary.
starbelly
approved these changes
May 7, 2023
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft to try and troubleshoot #199. (and then some 😄)This:
debugLogfunctionconsole.with appropriate calls tocore.console.__tests__totesttest-projectstotest/projectsmatchersrebar_corebreaking are fixednpm run testsare fixedCI is all ✅ again. We still get errors regarding hitting the GitHub API all too often, but that's outside the scope of this PR and there's already an ongoing PR for this.