Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref: (version) support to .tool-versions parsing #228

Merged
merged 4 commits into from Aug 15, 2023

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Aug 15, 2023

Description

This adds support for using source code elixir references in .tool-versions, e.g., elixir ref:v1.15.4.

  • I have performed a self-review of my changes (*I was not able to run the tests locally on my mac though)
  • I have read and understood the contributing guidelines

@dvic dvic changed the title Add support elixir ref in .tool-versions Add support for elixir ref in .tool-versions Aug 15, 2023
@dvic
Copy link
Contributor Author

dvic commented Aug 15, 2023

Using this syntax in your .tool-versions will compile elixir from source, the benefit for me is that I have goto definition for all Elixir source code in my editor.

@paulo-ferraz-oliveira
Copy link
Collaborator

Thanks for this. I'll comment on the changes, where appropriate.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Add support for elixir ref in .tool-versions Add ref: (version) support to .tool-versions parsing Aug 15, 2023
@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Aug 15, 2023

Tests are failing, most likely for:

  • using elixr instead of elixir, which will return undefined when trying to get a version
  • not having run npm run build-dist (as per the contributing guidelines) - it is possible you replaced the pull request template for the text we find in the above description, but it - the template - does mention you have self-reviewed and understood/followed the contributing guidelines 👍).

@dvic
Copy link
Contributor Author

dvic commented Aug 15, 2023

Should I add an issue for documentation? By the way the contributing link is broken in the template:

https://github.com/erlef/setup-beam/blob/main/erlef/setup-beam/blob/main/CONTRIBUTING.md, it should be
https://github.com/erlef/setup-beam/blob/main/CONTRIBUTING.md

@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Aug 15, 2023

There's no need to document 😄, as you're just implementing the standard, so whoever's using asdf should know (if they need it).

As for the "contributing" link, thanks for noticing. I'll fix it in a subsequent pull request.

Edit: the "contributing" link is set as /erlef/setup-beam/blob/main/CONTRIBUTING.md, so I don't understand why it'd be broken for you.

@paulo-ferraz-oliveira
Copy link
Collaborator

All checks successful, will merge. Thanks for this. It shall be present on the next release, hopefully soonish.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit f35f714 into erlef:main Aug 15, 2023
63 checks passed
@dvic
Copy link
Contributor Author

dvic commented Aug 25, 2023

Edit: the "contributing" link is set as /erlef/setup-beam/blob/main/CONTRIBUTING.md, so I don't understand why it'd be broken for you.

Now it works, I guess a github bug? 🤷🏻‍♂️

@dvic
Copy link
Contributor Author

dvic commented Jan 10, 2024

All checks successful, will merge. Thanks for this. It shall be present on the next release, hopefully soonish.

Any chance to cut a release ^^?

@paulo-ferraz-oliveira
Copy link
Collaborator

https://github.com/erlef/setup-beam/releases/tag/v1.17.0
v1.17 is the same commit
v1 was moved to the latest commit

@dvic
Copy link
Contributor Author

dvic commented Jan 10, 2024

https://github.com/erlef/setup-beam/releases/tag/v1.17.0 v1.17 is the same commit v1 was moved to the latest commit

ahhh thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants