Bump semver to 7.5.4 #240
Merged
Bump semver to 7.5.4 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the first release of this feature the version will always be non-undefined
|
We should probably create a minor release, after this one, for the security update, and for the new feature. |
starbelly
reviewed
Jan 13, 2024
| @@ -20,13 +20,6 @@ jobs: | |||
| sed -i'.bak' \ | |||
| -e "s/const setupBeamVersion = '.*'/const setupBeamVersion = '${SHA}'/g" \ | |||
| dist/index.js | |||
| # it always starts by being 'undefined' | |||
There was a problem hiding this comment.
Yes. I mean it's not directly related to my initial intention, but it doesn't always start by being undefined, since once we change it, it goes to the dist and then it's not undefined any more 👍
There was a problem hiding this comment.
I ended up tweaking it more after I tried to do another pull request and run into "issues". (basically we need to update the .js that we usually do and then run npm run build-dist instead of only doing the change in the dist files)
paulo-ferraz-oliveira
force-pushed
the
main
branch
from
68568e7
to
980f47e
Compare
We stop doing dist vs. src checks on non-main, since main will always run `npm run build-dist` We start changing `src/setup-beam.js` instead of `dist`, so local changes don't show changes to untouched elements We improve on the commit message to show this was not a pull request or human
starbelly
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
... as per Dependabot (CVE-2022-25883).