Add known branch exceptions to version matching #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josevalim, @grzuy, this adds an exception (to loose version matching) for "known" branches |
2 tasks
josevalim
reviewed
Jan 17, 2024
| @@ -10292,6 +10292,10 @@ function isRC(ver) { | |||
| return ver.match(xyzAbcVersion('^', '(?:-rc\\.?\\d+)')) | |||
| } | |||
|
|
|||
| function isKnownBranch(ver) { | |||
| return ['main', 'master', 'maint'].includes(ver) | |||
There was a problem hiding this comment.
If you want to be safer, you could match "maint" anywhere in the version, as OTP has maint-26, maint-25, and so on. :) Just saying, your call, we don't use it right now.
|
Looks great, thank you! |
paulo-ferraz-oliveira
force-pushed
the
main
branch
from
67f7a17
to
980f47e
Compare
Maybe doing it this way is better, since we don't "break" existing consumption elements Forcing `version-type: strict`, while explicit, would probably force some installations to use a too-specific Elixir version
paulo-ferraz-oliveira
force-pushed
the
fix/version-matching-expectations
branch
from
4d5fc33
to
7100c00
Compare
|
Perfect stuff. Thanks @starbelly. I'll release a patch now. |
|
v1, v1.17 and v1.17.1 released, pointing to the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maybe doing it this way is better, since we don't "break" existing consumption elements, while just adding to already existing exception
-rc-.Forcing
version-type: strict, while explicit, would probably force some installations to use a too-specific Elixir version, so we "fix" what we had to prevent that.Closes #241.