Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 24 #271

Merged
merged 4 commits into from
May 21, 2024
Merged

Add support for Ubuntu 24 #271

merged 4 commits into from
May 21, 2024

Conversation

sax
Copy link
Contributor

@sax sax commented May 20, 2024

Description

As of right now, the only packages available for OTP 27 are only available for Ubuntu 24.04. The setup-beam action only supports Ubuntu 22 or earlier.

These changes seem to work for me, though I am currently unable to run the tests... will add more info in the comments.

Closes #270.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sax
Copy link
Contributor Author

sax commented May 20, 2024

When I try to run the tests locally, I get the following error:

::error::Error: Got an exception when trying to parse non-JSON list {"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"}: Error: expected a list!

I don't see any information in the README or in the code about how to set up the project for running tests locally, but am happy to do so if someone can point me in a good direction.

@ericmj
Copy link
Collaborator

ericmj commented May 20, 2024

When I try to run the tests locally, I get the following error

You may have to generate a github access token [1] and set GITHUB_TOKEN.

[1] https://github.com/settings/tokens

@ericmj
Copy link
Collaborator

ericmj commented May 20, 2024

Can you add ubuntu-24.04 to the matrix here? https://github.com/erlef/setup-beam/blob/main/.github/workflows/ubuntu.yml

ubuntu-latest currently points to ubuntu-22.04.

@paulo-ferraz-oliveira Should we be explicitly with the ubuntu version instead of using latest?

@sax
Copy link
Contributor Author

sax commented May 20, 2024

Awesome, GITHUB_TOKEN was the thing I was missing. I may issue another pull request adding a reference to that in the README.

@ericmj One thing that I ran into today is that there are no Elixir builds yet for OTP 27 in builds.hex.pm. Do you have a preference for how many OTP versions (and which versions) I add to the matrix?

@ericmj
Copy link
Collaborator

ericmj commented May 20, 2024

One thing that I ran into today is that there are no Elixir builds yet for OTP 27 in builds.hex.pm.

The builds were delayed but are available now.

Do you have a preference for how many OTP versions (and which versions) I add to the matrix?

No, I would defer to @paulo-ferraz-oliveira here.

@sax
Copy link
Contributor Author

sax commented May 20, 2024

Ok, based on the CI failures and looking deeper at the test suite I just reran the tests locally in an Ubuntu container in docker.

@sax
Copy link
Contributor Author

sax commented May 21, 2024

Also to be very transparent I'm totally happy with anybody updating these changes, or throwing them away in favor of something else if that's decided to be better. Attribution is nice, but being able to update my apps to OTP 27 would be very nice 😄.

- otp-version: '26.0'
os: 'ubuntu-24.04'
version-type: 'strict'
- otp-version: '25.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- otp-version: '25.0'
- otp-version: '25'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in d2ad644

- otp-version: '27.0'
os: 'ubuntu-24.04'
version-type: 'strict'
- otp-version: '26.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- otp-version: '26.0'
- otp-version: '26'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in d2ad644

@@ -39,6 +39,14 @@ jobs:
elixir-version: '1.14.3'
os: 'ubuntu-latest'
version-type: 'strict'
- otp-version: '27.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- otp-version: '27.0'
- otp-version: '27'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way we make it choose the latest 27.x.y.z..., not the latest 27.0.y.z... 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in d2ad644

@paulo-ferraz-oliveira
Copy link
Collaborator

The proposed changes seem sane to me.

the only packages available for OTP 27 are only available for Ubuntu 24.04

What does this mean? From builds.txt? I think in the meantime more stuff is available, if that's the case.

Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge with or without the code change suggestions.

@sax
Copy link
Contributor Author

sax commented May 21, 2024

Cool! Decided to apply your suggestions as a single commit, vs 3 commits via the GitHub UI.

the only packages available for OTP 27 are only available for Ubuntu 24.04

Yeah looks like this was just an issue yesterday, and built are coming out for the different platforms. So not a real issue, just an explanation of why I chose to open this PR yesterday.

@paulo-ferraz-oliveira
Copy link
Collaborator

So not a real issue, just an explanation of why I chose to open this PR yesterday.

No prob. Now we're ubuntu24 ready, too 🤗. I'm gonna do some FOSS related to OTP 27 today, still, and it's possible I release the action's new version later (today, still). If I don't kindly remind my by commenting on this pr.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 618f138 into erlef:main May 21, 2024
65 checks passed
@paulo-ferraz-oliveira
Copy link
Collaborator

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 24.04 support
3 participants