Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wee_alloc
is no longer maintained and has a few critical open issues (memory leaks), see here.This reverts back to the recommended
dlmalloc-rs
.I ran the
wasm-pack.sh
file and everything seems fine but I have not tested this from JS directly. A few other PRs seem to just remove the extrawee_alloc
stuff with no other change so this should be fine. I have also not committed any of the changes that happen to thepkg/*
files when I runwasm-pack.sh
, should I do that?