Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #10

Merged
merged 3 commits into from May 5, 2024
Merged

Fix broken link #10

merged 3 commits into from May 5, 2024

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented May 5, 2024

The URLs generated by getDocsURL() are currently 404ing

I found another repo that may have the details

@karlhorky
Copy link
Contributor Author

Oh but this is the same one that is used below for getReplacementsDocUrl(), so I guess my suggestion here is incorrect

@43081j
Copy link
Contributor

43081j commented May 5, 2024

good catch!

it should be the url to the rule's docs:

https://github.com/es-tooling/eslint-plugin-depend/blob/main/docs/rules/${name}.md

@karlhorky
Copy link
Contributor Author

@43081j thanks! Updated.

@43081j
Copy link
Contributor

43081j commented May 5, 2024

one minor fix needed in rule-meta_test.ts it seems, just updating the assertion to match

will get a new version published once you can update that 👍

@43081j 43081j merged commit 1b97d04 into es-tooling:main May 5, 2024
3 checks passed
@43081j
Copy link
Contributor

43081j commented May 5, 2024

sorted it for you while i was in there already 👍

thanks a lot for fixing it 🙏

@karlhorky
Copy link
Contributor Author

@43081j ah sorry didn't see the CI failure, thanks for reviewing, fixing and merging!

@karlhorky karlhorky deleted the patch-1 branch May 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants