Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

chore: upgrade get-tsconfig #36

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

npdev453
Copy link

No description provided.

@npdev453
Copy link
Author

#36

@privatenumber
Copy link
Member

Can you add the new caching that comes with the new get-tsconfig?

@npdev453
Copy link
Author

npdev453 commented Aug 12, 2023

Can you add the new caching that comes with the new get-tsconfig?

Sure, but can you provide some explain in two words? I as can see than I can pass Map in third arg now, but how it should works inside context of this loader module where getTsconfig called just once (on start)?

@privatenumber
Copy link
Member

Yeah, just pass in a Map as the second or third argument. Here's a reference: privatenumber/esbuild-loader@544f4bd

@npdev453
Copy link
Author

Yeah, just pass in a Map as the second or third argument. Here's a reference: esbuild-kit/esbuild-loader@544f4bd

Done, but still not clear for me or is it just a foundation for the future?

src/index.ts Outdated Show resolved Hide resolved
@privatenumber
Copy link
Member

True, in this case it doesn't appear to be necessary right now.

But yeah, it sets us up for the future where we want the tsconfig to be looked up for each file in multi-tsconfig projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants