Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): Handle NamedExports of Imports, export * from and export as #511

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeltaEvo
Copy link

@DeltaEvo DeltaEvo commented May 20, 2018

Close #442
Part of #361

Todo:

  • Add cache to _getFactory because a file can be evaluated multiple time now ?
  • Integration tests

@DeltaEvo DeltaEvo changed the title [WIP]: fix(export): Handle NamedExports of Imports, export * from and export as fix(export): Handle NamedExports of Imports, export * from and export as May 21, 2018
@DanielRuf
Copy link

Hi, please use a dedicated branch next time instead of pushing to the master branch =)

Copy link

@ajmeese7 ajmeese7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Delta, this is great stuff! There were a few missed typedocs in there but overall this is awesome. I'm going to be merging this PR with some modifications into my fork of esdoc2 here shortly, since unfortunately both of these projects died. I'll be sure to mention your name to give credit where credit is due!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"export { XXXX };" does not get API documented
3 participants