New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to marked@0.6.2 to fix audit #543
base: master
Are you sure you want to change the base?
upgrade to marked@0.6.2 to fix audit #543
Conversation
Pls, merge this PR |
any news about this? |
I don't think the author of the package has time to look after this project anymore (at least, not as before). Unless someone else picks it up, bugfixes are going to be slow/null. |
I've sent him a message in twitter |
Getting this error when trying to install this fork :
|
Any response? |
@h13i32maru, @stefanwalther, @vovkasm, @utatti, @togana, @kdex, @hiroppy, @zandaqo, @staltz, @skratchdot, @reconbot, @raveclassic, @r7kamura, @pzuraq, @ouhouhsami, @mprobber, @koba04, @jan-molak, @isnifer, @hokaccha, @existentialism, @dliv, @dimitryvolkov, @bmeck, @bmaupin, @blindman, @atsushieno, @amercier, @RusinovAnton, @ProLoser, @MattMcFarland, @LukasHechenberger, @Kuniwak, @DragorWW, @22a who can help? |
As far as I know only @h13i32maru can merge changes to this repo, which is why @MattMcFarland forked it at https://github.com/esdoc2/esdoc2 |
Sadly, the esdoc2 fork @bmaupin mentions hasn't seen an update in a year either. Since I needed ESDoc to support TypeScript and monorepos, I have resorted to making a copy of I hope that @h13i32maru picks up ESDoc again or adds contributors to this repo, but in the meantime, you can consider using my "local patch/hack" approach. |
I'll probably be doing future work with TypeScript and typedoc, which thankfully seems to be well maintained. Although unfortunately that doesn't help for existing projects using esdoc unless I want to take the time to convert them. |
I wrote a simple bash script to work around this, since you just need the generated docs really, install all your esdoc dependencies, build your docs and then just uninstall them In my "scripts": {
"docs:build": "./scripts/docs-build"
} The contents of ESDOC="esdoc esdoc-ecmascript-proposal-plugin esdoc-standard-plugin"
npm i $ESDOC -D
./node_modules/.bin/esdoc
npm uninstall $ESDOC -D |
@rohan-deshpande maybe it's easier to use just npx esdoc |
@vvscode This is a good solution but I need the plugins, not sure you can use |
These were previously being rendered via esdoc (which uses marked's autolink rendering) as `mailto:` links. There are some [suggestions](https://gist.github.com/alexpeattie/4729247) about how one might disable or avoid autolinking but in this case the package identifiers are in backticks, producing weird behaviour similar to markedjs/marked#1327. Assuming the fix attached to this latter issue applied in this case, then a dependency upgrade of `marked` within `esdoc` might solve the problem, but there are [maintenance issues](esdoc/esdoc#543) there. Until that arrives, this is a workaround to avoiding the weird `mailto:` links on this page.
These were previously being rendered via esdoc (which uses marked's autolink rendering) as `mailto:` links. There are some [suggestions](https://gist.github.com/alexpeattie/4729247) about how one might disable or avoid autolinking but in this case the package identifiers are in backticks, producing weird behaviour similar to markedjs/marked#1327. Assuming the fix attached to this latter issue applied in this case, then a dependency upgrade of `marked` within `esdoc` might solve the problem, but there are [maintenance issues](esdoc/esdoc#543) there. Until that arrives, this is a workaround to avoiding the weird `mailto:` links on this page.
No description provided.