CAL - fetch pending transaction #794
Conversation
|
fixes #791 |
|
Hi @galbarm thanks for the contribution. I'll quickly play with it soon and if everything works i'll merge it. Thank you for your patience |
|
@esakal any chance you find time for this? |
|
@galbarm sorry for the late response, my availability and access to the computer is small during Jule/Aug. |
|
@eshaham I cannot merge it due to the CI checks for node v16 Can you please merge? |
|
@esakal, this is different - the v16 tests did not run because the branch has not taken the latest code from the |
|
@esakal we need to resolve conflicts first, tried to take a look, but it was a bit confusing. |
src/scrapers/visa-cal.ts
Outdated
| if (pendingData?.statusCode !== 1 && pendingData?.statusCode !== 96) throw new Error(`failed to fetch pending transactions for card ${card.last4Digits}. Message: ${pendingData?.title || ''}`); | ||
| if (!this.isCardPendingTransactionDetails(pendingData)) { | ||
| throw new Error('pendingData is not of type CardTransactionDetails'); | ||
| } |
There was a problem hiding this comment.
I'm not sure we should throw when the pending transactions phase is failed.
Most of the users want the transactions even without the pendings.
This reverts commit d6eca23.
Fix #791
Pending transactions in CAL, are retrieved via a separate endpoint than the completed transactions.
Added a request to fetch pending transactions from the new endpoint.