Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js<14.18.0 and 15 #42

Merged
merged 4 commits into from Jan 20, 2023
Merged

Drop support for Node.js<14.18.0 and 15 #42

merged 4 commits into from Jan 20, 2023

Conversation

ota-meshi
Copy link
Member

No description provided.

@ota-meshi ota-meshi requested a review from a team January 16, 2023 10:34
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe make some reusable GitHub Actions workflows which we can use here?

Like eg:

That way we could extract the boilerplate stuff from each individual eslint-community project and instead have them focus on what's specific for them individually.

package.json Outdated Show resolved Hide resolved
@ota-meshi ota-meshi changed the title Drop support for Node.js<14 Drop support for Node.js<12.22.0 Jan 17, 2023
@ota-meshi
Copy link
Member Author

That way we could extract the boilerplate stuff from each individual eslint-community project and instead have them focus on what's specific for them individually.

If it is possible, that would be good, but since most of our projects need to start from a fork, I'm concerned that having the same workflow for every project would be annoying.
@MichaelDeBoey What do you think?

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bumping to an already outdated Node.js version is a mistake which will just make us have to release another major real soon.

eslint-plugin-n should also be bumping it's engine requirement rather than this module lower itself for it.

@ota-meshi
Copy link
Member Author

Thank you for your comment.

I agree. I don't want to do a new major release any time soon.

I will change it to support "^14.18.0 || >=16.0.0" and above this time. We can expand the support range later if need it. No major release is needed in that case.

@ota-meshi ota-meshi changed the title Drop support for Node.js<12.22.0 Drop support for Node.js<14.18.0 and 15 Jan 18, 2023
@ota-meshi ota-meshi merged commit ef4d4aa into master Jan 20, 2023
@ota-meshi ota-meshi deleted the derop-old-node branch January 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants