Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-disable doesn't work with flat config #133

Closed
teppeis opened this issue Oct 16, 2023 · 3 comments
Closed

no-unused-disable doesn't work with flat config #133

teppeis opened this issue Oct 16, 2023 · 3 comments
Labels

Comments

@teppeis
Copy link

teppeis commented Oct 16, 2023

This rule is implemented by patching Linter, which seems to be causing this problem with new flat config.

The flat config allows reportUnusedDisableDirectives to be included in shareable config.
The new RFC will also allow for more configuration flexibility (in ESLint v9 ?).

So it would be good to make this rule deprecated in the future.

original: mysticatea#79

@ota-meshi
Copy link
Member

Thank you for posting the issue.
As you say, I think no-unused-disable should be deprecated.
I also think no-unused-enable can also be deprecated since the following PR was merged:
eslint/eslint#17611

@github-actions github-actions bot added the Stale label Dec 16, 2023
@teppeis
Copy link
Author

teppeis commented Dec 18, 2023

reportUnusedDisableDirectives:error released in v8.56.0 🚀

@github-actions github-actions bot removed the Stale label Dec 18, 2023
@github-actions github-actions bot added the Stale label Feb 16, 2024
Copy link

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants