Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-disable doesn't work with flat config #79

Open
teppeis opened this issue Sep 16, 2023 · 3 comments
Open

no-unused-disable doesn't work with flat config #79

teppeis opened this issue Sep 16, 2023 · 3 comments

Comments

@teppeis
Copy link

teppeis commented Sep 16, 2023

This rule is implemented by patching Linter, which seems to be causing this problem with new flat config.

The flat config allows reportUnusedDisableDirectives to be included in shareable config.
The new RFC will also allow for more configuration flexibility (in ESLint v9 ?).

So it would be good to make this rule deprecated in the future.

@MichaelDeBoey
Copy link

Hi @teppeis!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

@teppeis
Copy link
Author

teppeis commented Oct 16, 2023

@MichaelDeBoey I've reopened there: eslint-community#133
thank you!

@IanVS
Copy link

IanVS commented Mar 5, 2024

@MichaelDeBoey if this repo is unmaintained, shouldn't it be updated / marked as unmaintained in the README and potentially archived? @mysticatea that might help avoid confusion if you're not intending to work on this plugin anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants