Add new rule no-only-tests
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 agreed! |
aladdin-add
reviewed
Jun 24, 2021
|
|
||
| ## Rule Details | ||
|
|
||
| This rule flags a violation when a test case is using `only`. Note that this rule is not autofixable since automatically deleting the property would prevent developers from being able to use it during development. |
There was a problem hiding this comment.
maybe we can add a suggestion to fix it?
There was a problem hiding this comment.
Added a suggestion to remove the only: true property.
In a follow-up PR, I will update the README to make it more clear which rules provide suggestions.
| `, | ||
| output: null, | ||
| errors: [{ messageId: 'foundOnly', type: 'Property', line: 5, endLine: 5, column: 28, endColumn: 38 }], | ||
| }, |
There was a problem hiding this comment.
can you add some more tests like:
const {RuleTester} = require("eslint");
const tester = new RuleTester();
tester.run('foo', bar, {...});There was a problem hiding this comment.
Added imports to tests/docs.
bmish
force-pushed
the
no-only-tests
branch
2 times, most recently
from
2342d55
to
d8e1f1b
Compare
Most other test frameworks have a similar rule to this: * [ava/no-only-test](https://github.com/avajs/eslint-plugin-ava/blob/main/docs/rules/no-only-test.md) * [jest/no-focused-tests](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-focused-tests.md) * [mocha/no-exclusive-tests](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-exclusive-tests.md) * [qunit/no-only](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-only.md)
fisker
reviewed
Jul 7, 2021
| * @param {Token} token The token to check. | ||
| * @returns {boolean} `true` if the token is a comma token. | ||
| */ | ||
| function isCommaToken (token) { |
There was a problem hiding this comment.
Nice, didn't realize they came from there, fixed #156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
I named it
no-only-testsfor consistency with the no-identical-tests rule name. I would be equally happy to name itno-test-onlyor something else. Let me know if you want me to change the name.We should enable this as a
recommendedrule in v4 (#120).Most other test frameworks have a similar rule to this: