New: Add new rule prefer-message-ids
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bmish
commented
Jul 24, 2021
bmish
commented
- Adds new rule (see rule doc)
- Updates other rules to comply with it
bmish
force-pushed
the
prefer-message-ids
branch
from
69c6e80
to
b2021ac
Compare
aladdin-add
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
it can replace the eslint's internal rule: https://github.com/eslint/eslint/blob/master/tools/internal-rules/consistent-meta-messages.js
LGTM, thanks!
|
@aladdin-add yeah, that was actually the inspiration for it! Update: eslint/eslint#14841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.