Fix: False negative in prefer-message-ids rule
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
prefer-message-ids-empty-messages
branch
from
20ae7d8
to
7d2b29b
Compare
1 task
bmish
force-pushed
the
prefer-message-ids-empty-messages
branch
from
7d2b29b
to
e7b9b84
Compare
|
released in v3.5.3. 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rules,
contextis passed to functions that eventually callcontext.report(), likeno-duplicate-importsorpadding-lines-between-statements, and that will prevent this existing rule from flagging such instances ofcontext.report({ message: ... });.So in addition to flagging that, we should also flag when rules are simply missing
meta.messages, as all rules using message IDs should have at least one violation message defined in that object.This will unblock this PR: eslint/eslint#14841 (comment)
CC: @mdjermanovic