Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect function-style rules exported using a variable #235

Merged
merged 1 commit into from Dec 14, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 13, 2021

Updates our rules to detect old function-style rules that are defined in variables:

const rule = function(context) { return {} };
export default rule;
const rule = function(context) { return {} };
module.exports = rule;

In particular, this is needed so that our eslint-plugin/prefer-object-rule can detect and automatically convert these old function-style rules to the new object-style format.

Follow-up to:

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 💯

@aladdin-add aladdin-add merged commit e388a3a into eslint-community:master Dec 14, 2021
@bmish
Copy link
Member Author

bmish commented Dec 14, 2021

Thanks for the review! Side node, I'd love to be considered for becoming an official collaborator on this project if you folks are open to it @not-an-aardvark. Looking forward to helping out a lot more.

@aladdin-add
Copy link
Contributor

ah, I was thinking the same. But I don't have the admin access too. /_ \

@not-an-aardvark can you give me the admin access, so I can add @bmish, and some more (e.g. rename default branch to main).

@not-an-aardvark
Copy link
Contributor

I added @bmish to the repository and renamed the default branch to main. Let me know if there are other things I should do.

I'm not sure it's possible for me to give admin access because this is a user-owned repository. I think we would need to transfer the repository to an organization in order to do that. I would be fine with transferring it to an organization if that makes things easier.

@aladdin-add
Copy link
Contributor

great, thanks! 👍

nicholas has a plan to make an eslint-community org. this one sounds a good fit. I'll ping you when everything is ready. :)

@bmish
Copy link
Member Author

bmish commented Dec 15, 2021

Thanks! Yeah, definitely in favor of this being part of the future eslint-community org (I suggested that here too: eslint/eslint#14884 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants