Autodetect module type in recommends for FlatConfig

[coderaiser]

Would be great to have ability to require recommended preset with auto detect ESM/CommonJS in a similar to CommonJS way:

const nodeRecommendedScript = require("eslint-plugin-n/configs/recommended-script");

module.exports = [
    nodeRecommendedScript,
    {
        rules: {
            "n/exports-style": ["error", "module.exports"]
        }
    }
]

So it looks like:

const nodeRecommended = require("eslint-plugin-n/configs/recommended");

module.exports = [
    nodeRecommended,
]

[coderaiser]

Could you please publish new version :)?

[aladdin-add]

I'll release it when #114 get merged.

[coderaiser]

I have an error:

TypeError: Key "plugins": Cannot redefine plugin "n".

Coud you please help me with this?

[aladdin-add]

what is your config?

[aladdin-add]

seems like it's an issue that has been fixed. can you upgrade eslint to latest and retry?

eslint/eslint#16277

[coderaiser]

Here is my config https://github.com/coderaiser/putout/blob/v31.8.5/packages/eslint-plugin-putout/lib/config/index.js#L13,

what I changed is:

-const n = compat.config(nPlugin.configs.recommended);
+const n = nPlugin.configs['flat/mixed-esm-and-cjs'];

I have latest version of ESLint

I have this config-array-factory.js loaded:

[aladdin-add]

technically you cannot define a namespace for different plugins:

[plugins: {n: obj1}],
[plugins: {n: obj2}],

it will throw an error as you described.

In your case, you were using eslintrc and flat configs:

• @eslint/eslintrc to translate plugins: ["n"] to plugins: {n: obj} - obj is a normalized plugin object.
• flat/mixed-esm-and-cjs: plugins: {n: mod} - mod is another plugin object.

[aladdin-add]

so, this is not an issue in the package. I would recommend converting all the used eslint-plugin-n configs to flat.

I'm willing to make a PR for putout if you like. :)

[aladdin-add]

it should be resolved by removing this line:
https://github.com/coderaiser/putout/blob/4fac9bf44e80dd79d37ba7b93289b4fb531d8fc2/packages/eslint-plugin-putout/lib/index.js#L109

[coderaiser]

What about this rules I disabled?

Plugin n not required for them? And if it is absent they will be just ignored, is it right?

It works good, thank you!