feat: recommends for FlatConfig #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Aug 16, 2023
| globals, | ||
| }, | ||
| rules, | ||
| overrides, |
There was a problem hiding this comment.
but the flat config does not have overrides.
There was a problem hiding this comment.
Can we use compat here? Or write overrides in a different way? As an array items, like FlatESLint suggests, for example.
The thing is auto detecting of module type this what blocking me from upgrade to FlatESlint, since I have both types supported and think that one place to set module type in package.json is enough (like in legacy ESLint config plugin version)
There was a problem hiding this comment.
well, I think we can add 2 more presets:
"recommended": detecting the "type" field inpackage.json, userecommended-scriptif it'scommonjs/undefined; userecommended-moduleif it'smodule."mixed-esm-and-cjs"(a better name? 😏): exporting a flat configs like the eslintrc-stylerecommended.
|
closing in favor of #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #105, would be great to also have recommends, similar to legacy ESLint config.