Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect non-member expressions in n/no-sync #127

Merged

Conversation

scagood
Copy link

@scagood scagood commented Oct 6, 2023

This resolves named imports, or destructured requires:

import { readFileSync } from 'node:fs';

const file = readFileSync('/file/path');
const { readFileSync } = require('node:fs');

const file = readFileSync('/file/path');

This is the counterpoint to #128 and Option 1 for #102 (the simple option).

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 6d02512 into eslint-community:master Oct 11, 2023
15 checks passed
@scagood scagood deleted the no-sync-call-expression branch October 11, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants