feat: Detect sync functions from built in node modules

[scagood]

This is a different strategy to detect "Sync" functions by looking for the builtin node imports. Then we look for the usage of the function from there.

This means we can detect aliases like this too:

import { readFileSync as readFile } from 'node:fs';

readFile();

The tradeoff is that npm packages can now export Sync functions, eg:

import * as magic from 'npm:magic-module';

magic.performMagicSync();

This is the counterpoint to #127 and Option 2 for #102 (the complex option).

[aladdin-add]

nits: the name memberExpression seems a little confusing to me - it's also likely to be a non-memberexpression node?

[scagood]

Mm, I know what you mean.
I didn't really know what to call this, I called it memberExpression because I check to see if it's a memberExpression immediately after I create it 👀

Do you have any better name suggestions 😅

[aladdin-add]

something like parentNode or identifierParentNode?

[aladdin-add]

ok, given it's checked I think it's fine to be as-is. (naming is not an easy thing :). 😄

[scagood]

Mm, if #127 is merged shall I close this one?

[aladdin-add]

out of curiosity: is there a benefit to use .at() over [0]?
not sure .at() was supported since node.js v16.

[scagood]

This is just personal preference, I like the way .at behaves for negative numbers and for non numbers

I really didn't think about it that much, from a performance standpoint you probably want to use [0]. But I dont know 🤔

[scagood]

Just checked, it was 16.6 - when I am at my pc I will change it to an array index

[aladdin-add]

seems its support was added in node.js v16.8.0, while the package requires node.js >=16.0.0. let's just use [0]? 😅

[aladdin-add]

or you can fetch and rebase the main branch, and then do a force push:

$ git remote add up https://github.com/eslint-community/eslint-plugin-n
$ git fetch up
$ git rebase up/master
$ git push -f

[scagood]

I kinda meant this to be either #127 or #128. As they both solve roughly the same problem, but in different ways. I can rebase if you'd like

[aladdin-add]

👌 it's fine to close this one, thanks for doing this! ❤️