Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16 planned changes #42

Closed
aladdin-add opened this issue Aug 8, 2022 · 8 comments
Closed

v16 planned changes #42

aladdin-add opened this issue Aug 8, 2022 · 8 comments
Labels

Comments

@aladdin-add
Copy link

aladdin-add commented Aug 8, 2022

Starting a list of my desired breaking changes, feedback welcome. We can perform this release once we have compiled enough changes. We should watch out for any breaking changes needed for ESLint v9 in the coming months.

Planned:

Maybe:

  • Convert package to ESM or TypeScript?
@jordanbtucker
Copy link

jordanbtucker commented Oct 4, 2022

What's the rationale to setting ecmaVersion to 'latest'? It would seem like you would want to default this to the version compatible with the default version of Node.js.

@Lalem001
Copy link

Lalem001 commented Oct 4, 2022

Regarding ecmaVersion I would argue that it should be set dynamically based on the targeted node version. For example:

ecmaVersion nodeVersion (100%*) nodeVersion (>95%*) nodeVersion (>90%*)
2019 >= 12.4.0 >= 12.4.0 >= 12.4.0
2020 >= 16.4.0 >= 16.1.0 >= 14.0.0
2021 >= 16.4.0 >= 16.1.0 >= 15.0.0
2022 >= 16.11.0 >= 16.11.0
2023 >= 18.0.0 >= 18.0.0

* indicates the % coverage of ecmaScript per node.green

As far as which coverage level of ecmaScript to go with, I guess that could be up for debate. Maybe a strict/loose scenario?

@privatenumber
Copy link

I'm interested in tackling TypeScript conversion but it shouldn't be a breaking change if it's precompiled to CJS.

Would you be open to a pull request?

@voxpelli
Copy link
Member

I would personally prefer typing up the existing code rather than converting it to TypeScript.

TypeScript works just as well on type annotated JS code as it does on TS code gut the latter requires a new compilation step?

@privatenumber
Copy link

Types would be nice but the bigger benefit for me is ESM. The export style in this codebase was a little difficult to read so updating those would be a huge improvement.

Compilation step would be necessary but can be seamless and instantaneous using esbuild.

@piranna
Copy link

piranna commented Mar 10, 2023

Any update on this? There are some PRs like #87 pending to this. Also Node.js 14 will get EOL in one month, we should remove support for it too.

aladdin-add added a commit that referenced this issue Mar 13, 2023
aladdin-add added a commit that referenced this issue Mar 13, 2023
node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42
aladdin-add added a commit that referenced this issue Mar 29, 2023
node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42
aladdin-add added a commit that referenced this issue Mar 29, 2023
aladdin-add added a commit that referenced this issue Apr 18, 2023
aladdin-add added a commit that referenced this issue Apr 18, 2023
node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42
aladdin-add added a commit that referenced this issue Apr 21, 2023
node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42
aladdin-add added a commit that referenced this issue Apr 23, 2023
* feat!: engines.node defaults to 16.0.0

node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42

* docs: update docs to reflect the new default version

* docs: deduplication of the configured Node.js version range

* docs: fix node lts statement
aladdin-add added a commit that referenced this issue Apr 23, 2023
according to node.green, Node.js 16.0.0 supports all ES2021 features.

refs: #42
aladdin-add added a commit that referenced this issue Apr 23, 2023
according to node.green, Node.js 16.0.0 supports all ES2021 features.

refs: #42
@aladdin-add
Copy link
Author

update: just pushed a pre-release v16.0.0-0

will release the stable v16.0.0 as #95 landed.

@aladdin-add
Copy link
Author

v16 has been released.🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants