Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make most variants of module.exports = { ... } fixable #17

Merged
merged 15 commits into from
Apr 25, 2022
Merged

Make most variants of module.exports = { ... } fixable #17

merged 15 commits into from
Apr 25, 2022

Commits on Mar 4, 2020

  1. Make the exports style fixable under some circumstances

    @papandreou
    papandreou committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    f2efcd0 View commit details
    Browse the repository at this point in the history

  2. Handle generators

    @papandreou
    papandreou committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    c802465 View commit details
    Browse the repository at this point in the history

  3. Preserve comments from inside the object literal

    @papandreou
    papandreou committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    0d616ad View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Consistent semicolons in fixed output

    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9181e71 View commit details
    Browse the repository at this point in the history

  2. Test that we only replace top-level module.exports = {...}

    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f3e8691 View commit details
    Browse the repository at this point in the history

  3. Also replace module.exports.foo references

    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    49e5582 View commit details
    Browse the repository at this point in the history

  4. Split fixing code into two functions to avoid exceeding the complexit… 

    …y budget
    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8b1d4ca View commit details
    Browse the repository at this point in the history

  5. Also fix shorthand property occurrences

    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    de3d152 View commit details
    Browse the repository at this point in the history

  6. Make helper functions

    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    7bec563 View commit details
    Browse the repository at this point in the history

  7. Return undefined instead of [] 

    Both work and satisfy the linter
    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    435bfb4 View commit details
    Browse the repository at this point in the history

  8. Simplify a bit 

    Seems like in-between comments are only attached to one of the nodes
    @papandreou
    papandreou committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f877a55 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Don't use SourceCode#getComments (deprecated) 

    mysticatea#208 (comment)
    @papandreou
    papandreou committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    8d7cec4 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Be more defensive and try to match the patterns that we do want to fix 

    eslint-community#17 (comment)
    @papandreou
    papandreou committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    e783167 View commit details
    Browse the repository at this point in the history

  2. Return null instead of undefined 

    eslint-community#17 (comment)
eslint-community#17 (comment)
eslint-community#17 (comment)
    @papandreou
    papandreou committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    a4ec500 View commit details
    Browse the repository at this point in the history

  3. Add a few more test cases 

    eslint-community#17 (comment)
    @papandreou
    papandreou committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    8425c80 View commit details
    Browse the repository at this point in the history