Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsupported-features/node-builtins-modules #257

Merged
merged 4 commits into from Apr 30, 2024
Merged

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Apr 28, 2024

fixes #250

@aladdin-add aladdin-add marked this pull request as draft April 28, 2024 19:25
@scagood
Copy link

scagood commented Apr 28, 2024

I like this approach!

Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
@aladdin-add aladdin-add marked this pull request as ready for review April 30, 2024 02:41
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😊

Lets hope there are no more "hidden features" inside semver 😁

@aladdin-add aladdin-add merged commit 5c67787 into master Apr 30, 2024
19 checks passed
@aladdin-add aladdin-add deleted the issue250 branch April 30, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: unsupported-features/node-builtins-modules doesn't work for semver range in v17
2 participants