Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(node-builtins): Specify that only static properties are supported #272

Merged
merged 2 commits into from May 10, 2024
Merged

docs(node-builtins): Specify that only static properties are supported #272

merged 2 commits into from May 10, 2024

Conversation

scagood
Copy link

@scagood scagood commented May 10, 2024 •
edited

closes #40

@scagood
Copy link
Author

scagood commented May 10, 2024

I do want to get to the prototype behaviours in the future, but I think its a little too much currently

@scagood scagood marked this pull request as ready for review May 10, 2024 11:48
aladdin-add
aladdin-add approved these changes May 10, 2024
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 735a520 into master May 10, 2024
25 checks passed
@aladdin-add aladdin-add deleted the document-static-only branch May 10, 2024 14:01
@github-actions github-actions bot mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer.slice is deprecated
2 participants
@scagood @aladdin-add