Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: put __tests__/.eslintrc.json in root's config's override #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: put __tests__/.eslintrc.json in root's config's override #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,19 @@
"eslint-plugin/test-case-shorthand-strings": "error",
"node/no-unsupported-features": ["error", { "version": 6 }],
"prettier/prettier": "error"
}
},
"overrides": [
{
"files": ["__tests__/*.js"],
"plugins": ["jest"],
"extends": [
"eslint:recommended",
"plugin:jest/recommended",
"plugin:prettier/recommended"
],
Comment on lines +31 to +35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this as __tests__/.eslintrc.json was

Suggested change
"extends": [
"eslint:recommended",
"plugin:jest/recommended",
"plugin:prettier/recommended"
],
"extends": ["plugin:jest/recommended"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, overrides wipes out the whole property, that's why the full set of extends is required

"env": {
"jest/globals": true
}
}
]
}
7 changes: 0 additions & 7 deletions __tests__/.eslintrc.json
View file
Open in desktop

This file was deleted.