-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prefer-immutable-types): allow overriding options based on where the type is declared #804
Open
RebeccaStevens
wants to merge
1
commit into
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
Choose a base branch
from
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
base: 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RebeccaStevens and the rest of your teammates on Graphite |
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 14, 2024 14:13
0a6bd90
to
f31eb30
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 14, 2024 14:13
0130f0f
to
63f36f3
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 14, 2024 14:16
f31eb30
to
c24ea84
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 14, 2024 14:16
63f36f3
to
d246ac3
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 14, 2024 14:27
c24ea84
to
bf25112
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 14, 2024 14:27
d246ac3
to
7c09967
Compare
We probably want to bump the minimum ts version up to 4.7 |
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 15, 2024 06:54
bf25112
to
8bfc725
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 15, 2024 06:54
7c09967
to
d33e2c7
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 15, 2024 08:33
8bfc725
to
20f7137
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 15, 2024 08:33
d33e2c7
to
78839d6
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 16, 2024 09:34
20f7137
to
61e4e86
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 16, 2024 09:34
78839d6
to
a1a2526
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 17, 2024 12:16
61e4e86
to
90bb5eb
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 17, 2024 12:16
a1a2526
to
f62f410
Compare
This was referenced Apr 18, 2024
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 22, 2024 12:33
90bb5eb
to
71364aa
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 22, 2024 12:33
f62f410
to
414f358
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 22, 2024 15:25
71364aa
to
4a927d8
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 22, 2024 15:25
414f358
to
389d79d
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 22, 2024 16:03
4a927d8
to
8387695
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
April 22, 2024 16:03
389d79d
to
dd561f5
Compare
RebeccaStevens
force-pushed
the
04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared
branch
from
April 30, 2024 06:05
8387695
to
854b721
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 6, 2024 10:23
0903137
to
2c6e45b
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 6, 2024 11:05
e61e30a
to
c3b3266
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 6, 2024 11:06
2c6e45b
to
a09d559
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 6, 2024 11:30
c3b3266
to
8cf75a2
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 6, 2024 11:30
a09d559
to
0b09d6f
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 6, 2024 12:16
8cf75a2
to
3f2bfb9
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 6, 2024 12:16
0b09d6f
to
ff3c821
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 7, 2024 00:19
3f2bfb9
to
e205e84
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 7, 2024 00:19
ff3c821
to
08152bb
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 9, 2024 23:55
e205e84
to
bd0edd0
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 9, 2024 23:55
08152bb
to
b7d0cf8
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 12, 2024 06:09
bd0edd0
to
f988172
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 12, 2024 06:09
b7d0cf8
to
da6f22d
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 19, 2024 03:27
f988172
to
aa3c1d8
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 19, 2024 03:27
da6f22d
to
e98de95
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 25, 2024 10:23
aa3c1d8
to
fbc6119
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 25, 2024 10:23
e98de95
to
a20d63e
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 25, 2024 11:08
fbc6119
to
c845f8e
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 25, 2024 11:08
a20d63e
to
f730ae6
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 25, 2024 11:16
c845f8e
to
641b8b0
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 25, 2024 11:16
f730ae6
to
0713a0f
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 25, 2024 12:39
641b8b0
to
0e3f642
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 25, 2024 12:39
0713a0f
to
67f5e6e
Compare
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 25, 2024 13:32
0e3f642
to
5bd3589
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 25, 2024 13:32
67f5e6e
to
ac98f6b
Compare
…tions based on the type fix #800
RebeccaStevens
force-pushed
the
04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
branch
from
May 26, 2024 05:11
5bd3589
to
4c7cafd
Compare
RebeccaStevens
force-pushed
the
04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
branch
from
May 26, 2024 05:11
ac98f6b
to
525eb6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #800