feat: replace graphemer with Intl.Segmenter
#220
Merged
+9
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eslint-stylistic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 113 113
Lines 26451 26451
Branches 4441 4441
=======================================
Hits 26396 26396
Misses 55 55 ☔ View full report in Codecov by Sentry. |
antfu
approved these changes
Dec 11, 2023
|
Thanks! |
mergify bot
referenced
this pull request
in jsec/code-quality-tools
Dec 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@rushstack/eslint-patch](https://rushstack.io) ([source](https://togithub.com/microsoft/rushstack/tree/HEAD/eslint/eslint-patch)) | [`^1.6.0` -> `^1.6.1`](https://renovatebot.com/diffs/npm/@rushstack%2feslint-patch/1.6.0/1.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@stylistic/eslint-plugin](https://togithub.com/eslint-stylistic/eslint-stylistic) ([source](https://togithub.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin)) | [`^1.5.0` -> `^1.5.1`](https://renovatebot.com/diffs/npm/@stylistic%2feslint-plugin/1.5.0/1.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`^20.10.3` -> `^20.10.5`](https://renovatebot.com/diffs/npm/@types%2fnode/20.10.4/20.10.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`^6.13.2` -> `^6.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.13.2/6.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`^6.13.2` -> `^6.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.13.2/6.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`^8.55.0` -> `^8.56.0`](https://renovatebot.com/diffs/npm/eslint/8.55.0/8.56.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-import](https://togithub.com/import-js/eslint-plugin-import) | [`^2.29.0` -> `^2.29.1`](https://renovatebot.com/diffs/npm/eslint-plugin-import/2.29.0/2.29.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-n](https://togithub.com/eslint-community/eslint-plugin-n) | [`^16.3.1` -> `^16.4.0`](https://renovatebot.com/diffs/npm/eslint-plugin-n/16.3.1/16.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/rushstack (@​rushstack/eslint-patch)</summary> ### [`v1.6.1`](https://togithub.com/microsoft/rushstack/blob/HEAD/eslint/eslint-patch/CHANGELOG.md#161) [Compare Source](https://togithub.com/microsoft/rushstack/compare/2840be24a2b498e4998deac4fe47ef325d912dee...235c79b6058312e691d02668abadd1bd86faf78c) Fri, 15 Dec 2023 01:10:06 GMT ##### Patches - Fix bulk suppression patch's eslintrc detection in polyrepos </details> <details> <summary>eslint-stylistic/eslint-stylistic (@​stylistic/eslint-plugin)</summary> ### [`v1.5.1`](https://togithub.com/eslint-stylistic/eslint-stylistic/releases/tag/v1.5.1) [Compare Source](https://togithub.com/eslint-stylistic/eslint-stylistic/compare/v1.5.0...v1.5.1) ##### 🚀 Features - Replace `graphemer` with `Intl.Segmenter` - by [@​ota-meshi](https://togithub.com/ota-meshi) in [https://github.com/eslint-stylistic/eslint-stylistic/issues/220](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/220) [<samp>(e09f2)</samp>](https://togithub.com/eslint-stylistic/eslint-stylistic/commit/e09f2aa) ##### 🐞 Bug Fixes - Graphemer CJS interop, close [#​216](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/216) - by [@​antfu](https://togithub.com/antfu) in [https://github.com/eslint-stylistic/eslint-stylistic/issues/216](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/216) [<samp>(9ca6c)</samp>](https://togithub.com/eslint-stylistic/eslint-stylistic/commit/9ca6cb0) - **js/function-paren-newline**: Prevent newline error in type parameter - by [@​levchak0910](https://togithub.com/levchak0910) and [@​antfu](https://togithub.com/antfu) in [https://github.com/eslint-stylistic/eslint-stylistic/issues/207](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/207) [<samp>(c37f3)</samp>](https://togithub.com/eslint-stylistic/eslint-stylistic/commit/c37f3fe) - **ts/no-extra-parens**: Cover more unnecessary parens case - by [@​kecrily](https://togithub.com/kecrily) and [@​antfu](https://togithub.com/antfu) in [https://github.com/eslint-stylistic/eslint-stylistic/issues/217](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/217) [<samp>(1a7fd)</samp>](https://togithub.com/eslint-stylistic/eslint-stylistic/commit/1a7fdaa) - **ts/padding-line-between-statements**: Add new `function-overload` statement type, close [#​190](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/190) - by [@​antfu](https://togithub.com/antfu) in [https://github.com/eslint-stylistic/eslint-stylistic/issues/213](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/213) and [https://github.com/eslint-stylistic/eslint-stylistic/issues/190](https://togithub.com/eslint-stylistic/eslint-stylistic/issues/190) [<samp>(32296)</samp>](https://togithub.com/eslint-stylistic/eslint-stylistic/commit/3229635) ##### [View changes on GitHub](https://togithub.com/eslint-stylistic/eslint-stylistic/compare/v1.5.0...v1.5.1) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.15.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6150-2023-12-18) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.14.0...v6.15.0) ##### Features - **eslint-plugin:** \[no-useless-template-literals] add new rule ([#​7957](https://togithub.com/typescript-eslint/typescript-eslint/issues/7957)) ([ff75785](https://togithub.com/typescript-eslint/typescript-eslint/commit/ff75785f4c6cc41999f8ce946bfca469d6e40e50)), closes [#​2846](https://togithub.com/typescript-eslint/typescript-eslint/issues/2846) - require-array-sort-compare + toSorted ([#​8052](https://togithub.com/typescript-eslint/typescript-eslint/issues/8052)) ([c9661c8](https://togithub.com/typescript-eslint/typescript-eslint/commit/c9661c8bbf048e9fa3ef55985e1e2e82bc098b1a)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v6.14.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6140-2023-12-11) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.2...v6.14.0) ##### Bug Fixes - **eslint-plugin:** add no-unsafe-unary-minus, prefer-destructuring to disable-type-checked ([#​8038](https://togithub.com/typescript-eslint/typescript-eslint/issues/8038)) ([431cd15](https://togithub.com/typescript-eslint/typescript-eslint/commit/431cd1559f91795e958e03fd060ceaf79fb96f3a)) - **eslint-plugin:** correct message for `no-unsafe-unary-minus` ([#​7998](https://togithub.com/typescript-eslint/typescript-eslint/issues/7998)) ([705370a](https://togithub.com/typescript-eslint/typescript-eslint/commit/705370ac0d9c54081657b8855b398e57d6ea4ddb)) ##### Features - **eslint-plugin:** \[explicit-function-return-type] add support for typed class property definitions ([#​8027](https://togithub.com/typescript-eslint/typescript-eslint/issues/8027)) ([bff47d7](https://togithub.com/typescript-eslint/typescript-eslint/commit/bff47d7885bee3bbcb3a81eff273fe2f48580940)) - **eslint-plugin:** \[require-await] allow yielding Promise in async generators ([#​8003](https://togithub.com/typescript-eslint/typescript-eslint/issues/8003)) ([4c3e704](https://togithub.com/typescript-eslint/typescript-eslint/commit/4c3e704b97e698df7f72174c2d20714836d4d243)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.13.2](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.1...v6.13.2) (2023-12-04) **Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.13.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.0...v6.13.1) (2023-11-28) **Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.15.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6150-2023-12-18) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.14.0...v6.15.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ### [`v6.14.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6140-2023-12-11) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.2...v6.14.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.13.2](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.1...v6.13.2) (2023-12-04) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.13.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.13.0...v6.13.1) (2023-11-28) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.56.0`](https://togithub.com/eslint/eslint/releases/tag/v8.56.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.55.0...v8.56.0) ##### Features - [`0dd9704`](https://togithub.com/eslint/eslint/commit/0dd9704c4751e1cd02039f7d6485fee09bbccbf6) feat: Support custom severity when reporting unused disable directives ([#​17212](https://togithub.com/eslint/eslint/issues/17212)) (Bryan Mishkin) - [`31a7e3f`](https://togithub.com/eslint/eslint/commit/31a7e3fde491e36496b54e8905c766b31162d776) feat: fix no-restricted-properties false negatives with unknown objects ([#​17818](https://togithub.com/eslint/eslint/issues/17818)) (Arka Pratim Chaudhuri) ##### Bug Fixes - [`7d5e5f6`](https://togithub.com/eslint/eslint/commit/7d5e5f68849ae80caec0fc96ecceebccd348deec) fix: `TypeError: fs.exists is not a function` on read-only file system ([#​17846](https://togithub.com/eslint/eslint/issues/17846)) (Francesco Trotta) - [`74739c8`](https://togithub.com/eslint/eslint/commit/74739c849bbb6547b0e555ed8bb2ba1cbe0fdce4) fix: suggestion with invalid syntax in no-promise-executor-return rule ([#​17812](https://togithub.com/eslint/eslint/issues/17812)) (Bryan Mishkin) ##### Documentation - [`9007719`](https://togithub.com/eslint/eslint/commit/90077199fe519953f9af8664bf947db4e4958514) docs: update link in ways-to-extend.md ([#​17839](https://togithub.com/eslint/eslint/issues/17839)) (Amel SELMANE) - [`3a22236`](https://togithub.com/eslint/eslint/commit/3a22236f8d10af8a5bcafe56092651d3d681c99d) docs: Update README (GitHub Actions Bot) - [`54c3ca6`](https://togithub.com/eslint/eslint/commit/54c3ca6f2dcd2a7afd53f42fc32055a25587259e) docs: fix migration-guide example ([#​17829](https://togithub.com/eslint/eslint/issues/17829)) (Tanuj Kanti) - [`4391b71`](https://togithub.com/eslint/eslint/commit/4391b71e62b15e54b0493f0dce1ea053ebbc0689) docs: check config comments in rule examples ([#​17815](https://togithub.com/eslint/eslint/issues/17815)) (Francesco Trotta) - [`fd28363`](https://togithub.com/eslint/eslint/commit/fd2836342c2be4751b05fe0ba7cece17d1edecc8) docs: remove mention about ESLint stylistic rules in readme ([#​17810](https://togithub.com/eslint/eslint/issues/17810)) (Zwyx) - [`48ed5a6`](https://togithub.com/eslint/eslint/commit/48ed5a6dad478a14d3e823f137455c523f373e0b) docs: Update README (GitHub Actions Bot) ##### Chores - [`ba6af85`](https://togithub.com/eslint/eslint/commit/ba6af85c7d8ba55d37f8663aee949d148e441c1a) chore: upgrade [@​eslint/js](https://togithub.com/eslint/js)[@​8](https://togithub.com/8).56.0 ([#​17864](https://togithub.com/eslint/eslint/issues/17864)) (Milos Djermanovic) - [`60a531a`](https://togithub.com/eslint/eslint/commit/60a531a9c0811ddf718e26b9136e133f580b6c36) chore: package.json update for [@​eslint/js](https://togithub.com/eslint/js) release (Jenkins) - [`ba87a06`](https://togithub.com/eslint/eslint/commit/ba87a0651a65b52c3ac442b512dd9f4c2b4c5f57) chore: update dependency markdownlint to ^0.32.0 ([#​17783](https://togithub.com/eslint/eslint/issues/17783)) (renovate\[bot]) - [`9271d10`](https://togithub.com/eslint/eslint/commit/9271d10d9eabeafb0129a090f29191bfd14273c0) chore: add GitHub issue template for docs issues ([#​17845](https://togithub.com/eslint/eslint/issues/17845)) (Josh Goldberg ✨) - [`70a686b`](https://togithub.com/eslint/eslint/commit/70a686b3c1feac5eca98bbff9bd67175f550d5db) chore: Convert rule tests to FlatRuleTester ([#​17819](https://togithub.com/eslint/eslint/issues/17819)) (Nicholas C. Zakas) - [`f3a599d`](https://togithub.com/eslint/eslint/commit/f3a599d34c7080fc0b2c9a60b5e54dc98c22867c) chore: upgrade eslint-plugin-unicorn to v49.0.0 ([#​17837](https://togithub.com/eslint/eslint/issues/17837)) (唯然) - [`905d4b7`](https://togithub.com/eslint/eslint/commit/905d4b75ab2df42aba30622cee0f66b511397e2c) chore: upgrade eslint-plugin-eslint-plugin v5.2.1 ([#​17838](https://togithub.com/eslint/eslint/issues/17838)) (唯然) - [`4d7c3ce`](https://togithub.com/eslint/eslint/commit/4d7c3ce246e6b499f472342ef59496a47cc033d6) chore: update eslint-plugin-n v16.4.0 ([#​17836](https://togithub.com/eslint/eslint/issues/17836)) (唯然) - [`fd0c60c`](https://togithub.com/eslint/eslint/commit/fd0c60c3be1f213e5a6d69d8a3248e963619e155) ci: unpin Node.js 21.2.0 ([#​17821](https://togithub.com/eslint/eslint/issues/17821)) (Francesco Trotta) </details> <details> <summary>import-js/eslint-plugin-import (eslint-plugin-import)</summary> ### [`v2.29.1`](https://togithub.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2291---2023-12-14) [Compare Source](https://togithub.com/import-js/eslint-plugin-import/compare/v2.29.0...v2.29.1) ##### Fixed - \[`no-extraneous-dependencies`]: ignore `export type { ... } from '...'` when `includeTypes` is `false` (\[[#​2919](https://togithub.com/import-js/eslint-plugin-import/issues/2919)], thanks \[[@​Pandemic1617](https://togithub.com/Pandemic1617)]) - \[`no-unused-modules`]: support export patterns with array destructuring (\[[#​2930](https://togithub.com/import-js/eslint-plugin-import/issues/2930)], thanks \[[@​ljharb](https://togithub.com/ljharb)]) - \[Deps] update `tsconfig-paths` (\[[#​2447](https://togithub.com/import-js/eslint-plugin-import/issues/2447)], thanks \[[@​domdomegg](https://togithub.com/domdomegg)]) </details> <details> <summary>eslint-community/eslint-plugin-n (eslint-plugin-n)</summary> ### [`v16.4.0`](https://togithub.com/eslint-community/eslint-plugin-n/releases/tag/16.4.0) [Compare Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/16.3.1...16.4.0) - feat: eslint v9.0.0 compatibility (fixes [#​143](https://togithub.com/eslint-community/eslint-plugin-n/issues/143)) ([#​144](https://togithub.com/eslint-community/eslint-plugin-n/issues/144)) ([`b075568`](https://togithub.com/eslint-community/eslint-plugin-n/commit/b075568)) - docs: add playground (fixes [#​25](https://togithub.com/eslint-community/eslint-plugin-n/issues/25)) ([#​145](https://togithub.com/eslint-community/eslint-plugin-n/issues/145)) ([`8bd6c7e`](https://togithub.com/eslint-community/eslint-plugin-n/commit/8bd6c7e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm on friday" in timezone America/Detroit, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jsec/code-quality-tools). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
graphemerwithIntl.Segmenter.Linked Issues
close #219
Additional context