Many rule allow unwanted additionalProperties

[Dimava]

I see over 25 rules with

[k: string]: any;

which disappear if json-schema-to-typescript is configured with { additionalProperties: /* default to: */ false }

I think at least 75% of that is schema typos, and we should use { additionalProperties: /* default to: */ false }

If the type actually has additionalProperties it is always written in type (as Record types obviously require them to exist), while when it hasn't it may be just be forgotten

[Dimava]

[Shinigami92]

Oh nice there is a property for that? wow? This could actually fix all our issues 🎉

[Shinigami92]

I will check that tomorrow or you already did a PR

[Dimava]

I didnt

[Shinigami92]

I didnt

I meant: I will do a PR on my own tomorrow if you did not already send a PR from your side

sorry for misunderstandment 😅
I think english is not the native language for both of us 😅

[Dimava]

Other things that coiuld be fixed are

        ignore?: (string & { // string:not(...):not(...), should be just string here
          [k: string]: any;
        } & {
          [k: string]: any;
        })[];

and

        ignorePatterns?: any[]; // mostly string[]

and maybe a couple of annoying TS types that depend on ESLint types

[Dimava]

I didnt

I meant: I will do a PR on my own tomorrow if you did not already send a PR from your side

sorry for misunderstandment 😅 I think english is not the native language for both of us 😅

In my language "I will check that tomorrow or you already did a PR" would be read as a question, so I answered that 😅

[Dimava]

Some context-sensitive types like

export type regex = string & { _?: regex }; // string that is used as RegExp pattern
export type glob = string & { _?: regex }; // string which is used as glob pattern

could also be (very) useful, but that's hard to mantain

[Shinigami92]

I tried to configure additionalProperties to true and false but nothing changed

https://github.com/Shinigami92/eslint-define-config/blob/c8489871f1e409f306cd290051a09d4773ebb807/scripts/generate-rule-files/src/json-schema-to-ts.ts#L26-L34

So I think we will just use patching again
But we can apply this patch generally like we did here

https://github.com/Shinigami92/eslint-define-config/blob/c8489871f1e409f306cd290051a09d4773ebb807/scripts/generate-rule-files/src/json-schema-to-ts.ts#L8-L11

[Shinigami92]

@Dimava The [k: string]: any; itself is not a problem at all, it just means that other properties can be added to the object and mostly if you need that you should check the website documentation of the rule.

Only stuff like string & otherStuff is something like a bug and we might need to report that back to json-schema-to-typescript repo

But for now I fixed it with #190

[Shinigami92]

plugin types are now supported via @eslint-type/*
if there are any additionalProperties I think they need to be fixed in their respective meta schemas in the specific plugin