Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate predefined config of flat config #227

Merged
merged 3 commits into from Sep 22, 2023

Conversation

sxzz
Copy link
Collaborator

@sxzz sxzz commented Aug 24, 2023

closes #226

@sxzz sxzz requested a review from Shinigami92 as a code owner August 24, 2023 18:01
@DamianGlowala
Copy link

@Shinigami92, are we good to merge this PR?

@Shinigami92
Copy link
Collaborator

@Shinigami92, are we good to merge this PR?

yeah, we are, but I just gave this not so much prio, because it just adds docs to the code that marks it as deprecated
so it isn't in any kind of sense something that is urgent to merge and I would merge it when other stuff needs also to be merged and released in a new version

@Shinigami92 Shinigami92 merged commit 4e845f8 into main Sep 22, 2023
3 checks passed
@Shinigami92 Shinigami92 deleted the refactor/deprecated branch September 22, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predefined string configurations in flat config seem to be deprecated
3 participants