Conversation
Deploy preview for eslint ready! Built with commit 0f2927c |
I hope this doesn't negatively affect |
Thanks for working on this! I think it makes sense to have the webpack configs match as much as possible. Do you want to fix the merge conflict and I can test out the deploy preview? |
86253c6
to
0f2927c
Compare
Also, I noticed the demo was broken shortly before the release, probably after the sponsors commit Perhaps we should package-lock the demo, too? |
The reason I haven’t used a lockfile in the past is so that it pulls in the latest version of eslint right after it’s published. This isn’t a big deal right now since it’s installing the 6.x release line, but once we release v7 we’ll want to make sure it installs the version that was just released. I think we could automate updating to the latest release and upgrade the version when the site is generated, though. |
@mdjermanovic Do we still want to do this? I do think it would be best to maintain consistency between our configs here and in eslint/eslint. |
@kaicataldo sorry, I missed this. Got a notification that it was merged now, was there again some problem with the demo? |
No worries! No problems - thought it seemed like a good idea to try to keep our web pack configs as similar as possible in the two repos. |
Demo is currently broken because of the esquery module change.
This should fix it, similar to eslint/eslint#13076
Just had to add
"browser"
as well, bundling was failing ondebug
module without that. I guess we should do the same in the eslint/eslint repo, too.