Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Build: add webpack mainFields #707

Merged
merged 1 commit into from Jul 3, 2020
Merged

Build: add webpack mainFields #707

merged 1 commit into from Jul 3, 2020

Conversation

mdjermanovic
Copy link
Member

Demo is currently broken because of the esquery module change.

This should fix it, similar to eslint/eslint#13076

Just had to add "browser" as well, bundling was failing on debug module without that. I guess we should do the same in the eslint/eslint repo, too.

@netlify
Copy link

netlify bot commented Mar 28, 2020

Deploy preview for eslint ready!

Built with commit 0f2927c

https://deploy-preview-707--eslint.netlify.com

@mdjermanovic
Copy link
Member Author

I hope this doesn't negatively affect main.js in some way. Not sure how to test it thoroughly.

@kaicataldo
Copy link
Member

Thanks for working on this! I think it makes sense to have the webpack configs match as much as possible. Do you want to fix the merge conflict and I can test out the deploy preview?

@mdjermanovic
Copy link
Member Author

Done! This overrides change from #709, but I'm not sure if it's a better solution than #709, because this change applies to all dependencies. It should be normally better to use modules, for size. The particular problem with esquery is that it ends up having a different API.

@mdjermanovic
Copy link
Member Author

Also, I noticed the demo was broken shortly before the release, probably after the sponsors commit
af75efa was built and deployed.

Perhaps we should package-lock the demo, too?

@kaicataldo
Copy link
Member

The reason I haven’t used a lockfile in the past is so that it pulls in the latest version of eslint right after it’s published. This isn’t a big deal right now since it’s installing the 6.x release line, but once we release v7 we’ll want to make sure it installs the version that was just released. I think we could automate updating to the latest release and upgrade the version when the site is generated, though.

@kaicataldo
Copy link
Member

@mdjermanovic Do we still want to do this? I do think it would be best to maintain consistency between our configs here and in eslint/eslint.

@kaicataldo kaicataldo merged commit 6cf97b9 into master Jul 3, 2020
@kaicataldo kaicataldo deleted the webpack-esquery branch July 3, 2020 20:14
@mdjermanovic
Copy link
Member Author

@mdjermanovic Do we still want to do this? I do think it would be best to maintain consistency between our configs here and in eslint/eslint.

@kaicataldo sorry, I missed this. Got a notification that it was merged now, was there again some problem with the demo?

@kaicataldo
Copy link
Member

No worries! No problems - thought it seemed like a good idea to try to keep our web pack configs as similar as possible in the two repos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants