Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Fix: parser interface link #713

Closed
wants to merge 2 commits into from

Conversation

shahroq
Copy link

@shahroq shahroq commented Apr 20, 2020

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Apr 20, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 20, 2020
@netlify
Copy link

netlify bot commented Apr 20, 2020

Deploy preview for eslint ready!

Built with commit bc833d0

https://deploy-preview-713--eslint.netlify.app

@@ -63,7 +63,7 @@ Setting parser options helps ESLint determine what is a parsing error. All langu
By default, ESLint uses [Espree](https://github.com/eslint/espree) as its parser. You can optionally specify that a different parser should be used in your configuration file so long as the parser meets the following requirements:

1. It must be a Node module loadable from the config file where it appears. Usually, this means you should install the parser package separately using npm.
1. It must conform to the [parser interface](/docs/developer-guide/working-with-plugins#working-with-custom-parsers).
1. It must conform to the [parser interface](/docs/developer-guide/working-with-plugins#processors-in-plugins).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Agreed that the link is incorrect here. Could we actually link to /docs/developer-guide/working-with-custom-parsers instead?

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly and removed triage An ESLint team member will look at this issue soon labels Apr 20, 2020
@kaicataldo
Copy link
Member

Ah, and this change actually needs to happen in the eslint/eslint repo, since we copy those files over into this repo when we release the site. Otherwise, this will be overwritten by what's in the other repo.

@btmills
Copy link
Member

btmills commented May 29, 2020

This is now fixed and live! The fix in eslint/eslint#12965 was merged back in February, but it went into the v7 prereleases, so it wasn't live on the site until we shipped v7.0.0 final a few weeks ago. Sorry about the delay there, and thanks for helping to improve ESLint!

@btmills btmills closed this May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants