chore: Correct examples for no-param-reassign #719
Conversation
eslint-deprecated
bot
added
the
triage
wdoug
changed the title
|
Deploy preview for eslint ready! Built with commit cb4dceb |
Specifically for parameter "ignorePropertyModificationsForRegex"
| @@ -137,15 +137,15 @@ Examples of **correct** code for the `{ "props": true }` option with `"ignorePro | |||
| ```js | |||
| /*eslint no-param-reassign: ["error", { "props": true, "ignorePropertyModificationsForRegex": ["^bar"] }]*/ | |||
|
|
|||
| function foo(bar) { | |||
| function foo(barVar) { | |||
There was a problem hiding this comment.
Thanks for doing this. Do you mind making this PR over in the https://github.com/eslint/eslint repo? We copy all the documentation from there, so this will get overwritten during our next release.
There was a problem hiding this comment.
Hmm. Is it this file? According to that file, this docs issue was already fixed back in December. Has it just not gone through a release yet?
There was a problem hiding this comment.
If everything gets copied from the https://github.com/eslint/eslint repo, it would be nice to the "Edit this page" links at the bottom of the page point to the other repo instead of this one. I'm trying to wrap my head around the process here.
There was a problem hiding this comment.
@wdoug it looks like “Edit this page” does go to the correct file. You’ll note there’s an edit_link field at the top of this file indicating the URL to use.
I’m not sure why the change was fixed in the main repo and didn’t end up in the live site. 🤔
There was a problem hiding this comment.
It looks like it was the very first PR to land in master when we started the v7.0.0 prereleases (you can see it here), and so this is currently published in the v7.0.0 docs. This should be fixed by our release this Friday.
I don't think this is a bug, but an unfortunate side effect of our release process taking so long this major release cycle.
Specifically for parameter "ignorePropertyModificationsForRegex"