This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Fix: Edit this page links #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
commented
Apr 28, 2020
| @@ -2,8 +2,8 @@ | |||
| <div class="container"> | |||
| <footer> | |||
| <ul class="list-inline"> | |||
| {% if page.edit_link %} | |||
| <li><a href="{{ page.edit_link }}">Edit this page</a></li> | |||
| {% if edit_link %} | |||
There was a problem hiding this comment.
The root of the problem - this data is at the top level, not nested in page
kaicataldo
commented
Apr 28, 2020
| @@ -1,7 +1,6 @@ | |||
| --- | |||
| title: 404 | |||
| layout: doc | |||
| edit_link: https://github.com/eslint/eslint.github.io/edit/master/_pages/404.md | |||
There was a problem hiding this comment.
These are generated by line 8 of _includes/footer.liquid,
kaicataldo
commented
Apr 28, 2020
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: ESLint Contributor License Agreement | |||
| layout: content-only | |||
| edit_link: https://github.com/eslint/eslint.github.io/edit/master/_pages/cla.md | |||
| edit_link: https://github.com/eslint/website/edit/master/_pages/cla.md | |||
There was a problem hiding this comment.
This redirects correctly, but we might as well update it.
kaicataldo
force-pushed
the
fix-edit-links
branch
from
2577157
to
5d89cba
Compare
|
|
kaicataldo
force-pushed
the
fix-edit-links
branch
from
5d89cba
to
2577157
Compare
kaicataldo
force-pushed
the
fix-edit-links
branch
from
2577157
to
f54384b
Compare
|
Deploy preview for eslint ready! Built with commit 2577157 |
kaicataldo
added
bug
|
Deploy preview for eslint ready! Built with commit f54384b |
nzakas
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here, there are a number of broken "Edit this page" links. This PR fixes them!