Update: disable experimental plugins by default #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
force-pushed
the
disable-experimental-plugins
branch
from
ae00b27
to
255a5d9
Compare
|
I am ok with the change but I would add |
|
With the current set of plugins, the bot doesn't leave any comments anyway, so I don't think it makes sense to have the duplicate comments plugin running. |
gyandeeps
approved these changes
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want it to be as easy as possible to replace the current version of
eslintbotwith this bot, so this PR disables the experimental plugins by default so that we can replicate the currenteslintbotbehavior. I think we can reenable the experimental plugins after we resolve design issues like #15 and #22.