Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standardize npm script names #19

Merged
merged 3 commits into from Aug 25, 2023
Merged

chore: standardize npm script names #19

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
705f65f
chore: standardize npm script names
snitin315 Jul 29, 2023
39a4b5c
chore: update scripts
snitin315 Aug 2, 2023
9db4f04
chore: remove redundant script
snitin315 Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Expand Up @@ -17,13 +17,13 @@
],
"scripts": {
"lint": "eslint .",
"test": "mocha ./tests/lib/**/*.js",
"new-rule-format": "node ./bin/eslint-transforms.js -t ./lib/new-rule-format/new-rule-format.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on what this script is doing? Per the new standard, with the exception of npm life cycle scripts all scripts should begin with build:, release:, lint:, start:, or test:.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can prefix it with build:, it seems to be updating rule from the old format to new format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a helper to run the transform on a file locally but isn't actually used as part of the build process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it doesn't seem to fit any of the build:, release:, lint:, start:, or test: categories. Should we keep it as-is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove it.

Agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

"generate-release": "eslint-generate-release",
"generate-alpharelease": "eslint-generate-prerelease alpha",
"generate-betarelease": "eslint-generate-prerelease beta",
"generate-rcrelease": "eslint-generate-prerelease rc",
"publish-release": "eslint-publish-release"
"release:generate:latest": "eslint-generate-release",
"release:generate:alpha": "eslint-generate-prerelease alpha",
"release:generate:beta": "eslint-generate-prerelease beta",
"release:generate:rc": "eslint-generate-prerelease rc",
"release:publish": "eslint-publish-release",
"test": "mocha ./tests/lib/**/*.js"
},
"devDependencies": {
"chai": "^3.5.0",
Expand Down