Breaking: drop node v10/v13/v15 (refs eslint/eslint#14023) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s make sure we sync these changes with the final changes in the eslint repo |
Merged
brettz9
added a commit
to brettz9/eslint-visitor-keys
that referenced
this pull request
Jun 22, 2021
By "final changes", do you just mean whatever the latest is by the time this is merged. With a quick look, I didn't see a current issue or PR to add |
|
Oh, apologies, I guess it must be eslint/eslint#14023 as in this issue title. |
|
Yes, sorry, that’s the correct issue. Was replying on my phone :) |
nzakas
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Breaking: Switch to ESM * Chore: Sync engines changes with #23; add CI to reflect #23 * Fix: Add `dist` to `files` * New: Export `package.json` * Update package.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Docs: Show CommonJS usage as well * Refactor: Align with espree re: ESM * Refactor: Switch from JSON to ESM * Chore: Add linting devDeps. * Refactor: Remove no longer needed `external` * Test: Add `commonjs.cjs` test * Refactor: Remove dupe `env` key * Breaking: Change to named exports * Update README.md Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Refactor: freeze in keys file * Update package.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update .eslintrc.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update .eslintrc.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update .eslintrc.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Test: Split cjs and js tests * Refactor: Avoid freezing unused array * Refactor: Stop exporting map file * Refactor: Drop `default` Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.