New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update discord info in issue template #383

Merged

harish-sethuraman merged 1 commit into eslint:main from amareshsm:issue-template-update

Dec 16, 2022

Member

amareshsm commented Dec 15, 2022

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Updated name and about. Similar to eslint/eslint#16663

netlify bot commented Dec 15, 2022 •

edited

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`e7907bf`

eslint-github-bot bot added the triage label

eslint-github-bot bot commented Dec 15, 2022

Hi @amareshsm!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/639aa5e5b90d1b0008121b4a
😎 Deploy Preview	https://deploy-preview-383--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/639aa5e50efafd000957ec69
😎 Deploy Preview	https://deploy-preview-383--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/639aa5e5a3813e0008c231ad
😎 Deploy Preview	https://deploy-preview-383--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


          chore: update discord info in issue template

e7907bf

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/639aa5e59dd22900089f0881
😎 Deploy Preview	https://deploy-preview-383--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

amareshsm force-pushed the issue-template-update branch from 5a79a08 to e7907bf Compare

December 15, 2022 04:43

eslint-github-bot bot added the chore label

amareshsm added accepted and removed chore labels

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/639aa5e5abbf940009d8ac9f
😎 Deploy Preview	https://deploy-preview-383--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/639aa5e56449100008dcc7b0
😎 Deploy Preview	https://deploy-preview-383--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 15, 2022 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`e7907bf`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/639aa5e5e0dd640008e924af
😎 Deploy Preview	https://deploy-preview-383--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

harish-sethuraman approved these changes

View reviewed changes

Member

harish-sethuraman left a comment

LGTM

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM. @harish-sethuraman you didn't mention why you didn't merge this, so leaving open just in case. :)

Member

harish-sethuraman commented Dec 16, 2022

Was waiting for 2nd reviewer :)

harish-sethuraman merged commit c169745 into eslint:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment