Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: footer social icons layout with nowrap #386

Merged
merged 2 commits into from Dec 18, 2022
Merged

fix: footer social icons layout with nowrap #386

merged 2 commits into from Dec 18, 2022

Conversation

shanpriyan
Copy link
Contributor

@shanpriyan shanpriyan commented Dec 16, 2022 •
edited

Prerequisites checklist

What is the purpose of this pull request?

Fixed footer socials icon with nowrap

What changes did you make? (Give an overview)

Homepage

image
image

Playground

image
image

Related Issues

Ref #381 (comment)

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 288b8fd

@eslint-github-bot eslint-github-bot bot added bug Something isn't working triage labels Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/639c922cdf87f90008c37dc2
😎 Deploy Preview https://deploy-preview-386--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/639c922cbd7e0a00094c75b6
😎 Deploy Preview https://deploy-preview-386--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/639c922dceddd10008ce62dd
😎 Deploy Preview https://deploy-preview-386--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/639c922c035c7100095bb26a
😎 Deploy Preview https://deploy-preview-386--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/639c922c2d0d70000732a74c
😎 Deploy Preview https://deploy-preview-386--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/639c922cd51eb300082470c0
😎 Deploy Preview https://deploy-preview-386--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 288b8fd
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/639c922c0cf4260008571984
😎 Deploy Preview https://deploy-preview-386--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shanpriyan shanpriyan mentioned this pull request Dec 16, 2022
Closed
1 task
@shanpriyan shanpriyan changed the title fix: footer socials icon layout with nowrap fix: footer social icons layout with nowrap Dec 16, 2022
kecrily
kecrily approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need someone else to check again

@harish-sethuraman
Copy link
Member

Hey I guess #382 PR is also solving the same issue already. Please refrain from raising another PR while someone else is working on the same 😕. @amareshsm would you like to see if this works?

@shanpriyan
Copy link
Contributor Author

Hey I guess #382 PR is also solving the same issue already. Please refrain from raising another PR while someone else is working on the same confused. @amareshsm would you like to see if this works?

Hey, #382 PR wraps the icons to next line. This PR prevents the icon from wrapping and is a follow-up of #382 (comment)

@amareshsm
Copy link
Member

Hey I guess #382 PR is also solving the same issue already. Please refrain from raising another PR while someone else is working on the same 😕. @amareshsm would you like to see if this works?

Hey, #382 PR wraps the icons to next line. This PR prevents the icon from wrapping and is a follow-up of #382 (comment)

Ya, #382 wraps the icons. But both PRs solve the same layout issue. Initially, we decided to wrap the icons. So I sent a PR.

@amareshsm
Copy link
Member

Hey I guess #382 PR is also solving the same issue already. Please refrain from raising another PR while someone else is working on the same 😕. @amareshsm would you like to see if this works?

Yes, this works it seems.

amareshsm
amareshsm approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving this for others' opinion. If we are fine with this approach we can close #382.

harish-sethuraman
harish-sethuraman approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@harish-sethuraman harish-sethuraman merged commit 11a51b1 into eslint:main Dec 18, 2022
@harish-sethuraman
Copy link
Member

harish-sethuraman commented Dec 18, 2022 •
edited

@amareshsm lets do the same in the main eslint/eslint too 👍🏻

@shanpriyan shanpriyan deleted the fix/nowrap-socials branch December 18, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amareshsm amareshsm amareshsm approved these changes

@harish-sethuraman harish-sethuraman harish-sethuraman approved these changes

@kecrily kecrily kecrily approved these changes

Assignees
No one assigned
Labels
bug Something isn't working playground triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shanpriyan @harish-sethuraman @amareshsm @kecrily