Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable docs IA update redirects for zh-hans site #434

Merged
merged 1 commit into from Apr 23, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

After merging eslint/zh-hans.docs.eslint.org#95, which included URL changes from eslint/eslint#16665, we forgot to enable redirects (#388) for the zh-hans site.

What changes did you make? (Give an overview)

Updated redirects template to enable docs IA update redirects for the zh-hans site.

Redirects from source-code to development-environment (#409) are still specific for the en site only because the change (eslint/eslint#16780) was merged for v8.33.0, while the zh-hans docs site is currently synced with 8.32.0.

Related Issues

No.

Is there anything you'd like reviewers to focus on?

Please double check how this change affects the _site/_redirects file:

@mdjermanovic mdjermanovic added bug Something isn't working accepted labels Apr 22, 2023
@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/644467101b10fa00084472c1
😎 Deploy Preview https://deploy-preview-434--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/644467111b10fa00084472c6
😎 Deploy Preview https://deploy-preview-434--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/64446711318b6d00082cde1d
😎 Deploy Preview https://deploy-preview-434--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6444671159280f0008820771
😎 Deploy Preview https://deploy-preview-434--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/64446711deb71a0008e64db7
😎 Deploy Preview https://deploy-preview-434--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6444671176be300008649885
😎 Deploy Preview https://deploy-preview-434--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/64446711ff3f63000851f22a
😎 Deploy Preview https://deploy-preview-434--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit a8471f4
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/64446711318b6d00082cde22
😎 Deploy Preview https://deploy-preview-434--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amareshsm amareshsm merged commit a48c0c9 into main Apr 23, 2023
45 checks passed
@amareshsm amareshsm deleted the zh-hans-redirects branch April 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants